Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: content/browser/transition_request_manager.h

Issue 297973002: Navigation transitions: Block first response until after transitions have run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes from review. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/transition_request_manager.h
diff --git a/content/browser/transition_request_manager.h b/content/browser/transition_request_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..bbf631409a29c52dc455cc70fc8080a695d3b4e4
--- /dev/null
+++ b/content/browser/transition_request_manager.h
@@ -0,0 +1,62 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_TRANSITION_REQUEST_MANAGER_H_
+#define CONTENT_BROWSER_TRANSITION_REQUEST_MANAGER_H_
+
+#include <set>
+#include <utility>
+
+#include "base/basictypes.h"
+#include "base/synchronization/lock.h"
+
+template <typename T>
+struct DefaultSingletonTraits;
+
+namespace content {
+
+// TransitionRequestManager is used to handle bookkeeping for transition
+// requests and responses between the UI and IO threads.
+//
+// TransitionRequestManager is a singleton that may be used on any thread.
+//
+class TransitionRequestManager {
+ public:
+ // Returns the singleton instance.
+ static TransitionRequestManager* GetInstance();
+
+ // Returns whether the RenderViewHost specified by the given IDs currently
nasko 2014/06/02 21:59:33 Let's use RenderFrameHost, RenderViewHost doesn't
shatch 2014/06/02 23:40:40 Done.
+ // has a pending transition request. If so, we will have to delay the
+ // response until the embedder resumes the request.
+ bool HasPendingTransitionRequest(int process_id, int render_view_id);
+
+ // Sets whether the RenderViewHost specified by the given IDs currently has a
+ // pending transition request. Called by RenderFrameHost on the UI thread.
+ void SetHasPendingTransitionRequest(int process_id,
+ int render_view_id,
+ bool has_pending);
+
+ private:
+ friend struct DefaultSingletonTraits<TransitionRequestManager>;
+ typedef std::set<std::pair<int, int> > RenderViewSet;
+
+ TransitionRequestManager();
+ ~TransitionRequestManager();
+
+ // You must acquire this lock before reading or writing any members of this
+ // class. You must not block while holding this lock.
+ base::Lock lock_;
+
+ // Set of (render_process_host_id, render_view_id) pairs of all
+ // RenderViewHosts that have pending transition requests. Used to pass
+ // information to the CrossSiteResourceHandler without doing a round-trip
+ // between IO->UI->IO threads.
+ RenderViewSet pending_transition_views_;
+
+ DISALLOW_COPY_AND_ASSIGN(TransitionRequestManager);
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_TRANSITION_REQUEST_MANAGER_H_

Powered by Google App Engine
This is Rietveld 408576698