content/common/transition_request_messages.h - Issue 297973002: Navigation transitions: Block first response until after transitions have run.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/transition_request_messages.h

Issue 297973002: Navigation transitions: Block first response until after transitions have run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes from review. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // IPC messages for navigation transitions.

	6 // Multiply-included message file, no include guard.

	7

	8 #include "base/memory/shared_memory.h"

	9 #include "content/public/common/common_param_traits.h"

	10 #include "ipc/ipc_message_macros.h"

	11

	12 #define IPC_MESSAGE_START TransitionRequestMsgStart

	13

	14 // Messages sent from the renderer to the browser.

	15 IPC_MESSAGE_ROUTED1(TransitionRequestHostMsg_SetHasPendingTransitionRequest,
	jam 2014/06/16 03:46:10 since the ipc is dispatched in one class, it shoul since the ipc is dispatched in one class, it should be a CONTROL ipc. the first parameter can be render_frame_id shatch 2014/06/16 22:32:19 Done. Show quoted text On 2014/06/16 03:46:10, jam wrote: > since the ipc is dispatched in one class, it should be a CONTROL ipc. the first > parameter can be render_frame_id Done.
	16 bool /* is_transition */)

OLD	NEW

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/common/content_message_generator.h ('k') | content/content_browser.gypi » ('j') | no next file with comments »