Navigation transitions: Block first response until after transitions have run.

content/browser/renderer_host/render_process_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_BROWSER_RENDER_PROCESS_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_BROWSER_RENDER_PROCESS_HOST_IMPL_H_
 
 #include <map>
 #include <queue>
 #include <string>
@@ skipping 109 matching lines @@
   virtual bool FastShutdownStarted() const OVERRIDE;
   virtual base::TimeDelta GetChildProcessIdleTime() const OVERRIDE;
   virtual void ResumeRequestsForView(int route_id) OVERRIDE;
   virtual void FilterURL(bool empty_allowed, GURL* url) OVERRIDE;
 #if defined(ENABLE_WEBRTC)
   virtual void EnableAecDump(const base::FilePath& file) OVERRIDE;
   virtual void DisableAecDump() OVERRIDE;
   virtual void SetWebRtcLogMessageCallback(
       base::Callback<void(const std::string&)> callback) OVERRIDE;
 #endif
   virtual void ResumeDeferredNavigation(const GlobalRequestID& request_id)

[jam, 2014/06/11 02:00:21]

i think you copied the pattern for this one by putting it in the virtual
section. i see that the only caller to this is inside content. if you can move
this to RenderProcessHostImpl as a method and out of RenderProcessHost interface
with the change below, that would be great

[shatch, 2014/06/14 00:41:37]

Done.

       OVERRIDE;
+  virtual void ResumeResponseDeferredAtStart(
+      const GlobalRequestID& request_id) OVERRIDE;

[jam, 2014/06/11 02:00:21]

this isn't overridding a method from the interface (which makes sense, since
it's not called by chrome), so put this as a non-virtual method

[shatch, 2014/06/14 00:41:37]

Done.

   virtual void NotifyTimezoneChange() OVERRIDE;
 
   // IPC::Sender via RenderProcessHost.
   virtual bool Send(IPC::Message* msg) OVERRIDE;
 
   // IPC::Listener via RenderProcessHost.
   virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE;
   virtual void OnChannelConnected(int32 peer_pid) OVERRIDE;
   virtual void OnChannelError() OVERRIDE;
   virtual void OnBadMessageReceived(const IPC::Message& message) OVERRIDE;
@@ skipping 282 matching lines @@
   base::TimeTicks survive_for_worker_start_time_;
 
   base::WeakPtrFactory<RenderProcessHostImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderProcessHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_BROWSER_RENDER_PROCESS_HOST_IMPL_H_