Navigation transitions: Block first response until after transitions have run.

content/public/browser/web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 329 matching lines @@
   // Stop any pending navigation.
   virtual void Stop() = 0;
 
   // Creates a new WebContents with the same state as this one. The returned
   // heap-allocated pointer is owned by the caller.
   virtual WebContents* Clone() = 0;
 
   // Reloads the focused frame.
   virtual void ReloadFocusedFrame(bool ignore_cache) = 0;
 
+  // Notifies the TransitionRequestManager that the main frame navigation is
+  // a transition navigation.
+  virtual void SetHasPendingTransitionRequest(bool has_pending_transition) = 0;

[jam, 2014/06/10 05:54:56]

is the only caller of this the test? if so, it should have a ForTesting suffix.

also, since these methods aren't called by chrome, they shouldn't be on the
public interface. i.e. they should only be on WebContentsImpl. see
http://www.chromium.org/developers/content-module/content-api

[shatch, 2014/06/10 20:20:24]

The intention was for the java side to control the transition, and call
SetHasPendingTransitionRequest through ContentViewCore (which looks like I
missed, added to the CL).

Cool, removed these from WebContents, only exist on WebContentsImpl now.

+
+  // Notifies the main frame that it can continue navigation (if it was deferred
+  // immediately at first response).
+  virtual void ResumeResponseDeferredAtStart() = 0;
+
   // Editing commands ----------------------------------------------------------
 
   virtual void Undo() = 0;
   virtual void Redo() = 0;
   virtual void Cut() = 0;
   virtual void Copy() = 0;
   virtual void CopyToFindPboard() = 0;
   virtual void Paste() = 0;
   virtual void PasteAndMatchStyle() = 0;
   virtual void Delete() = 0;
@@ skipping 247 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class WebContentsImpl;
   WebContents() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_