Issue 297963006: Introduce View::CanProcessEventsWithinSubtree()

Issue 297963006: Introduce View::CanProcessEventsWithinSubtree() (Closed)

Created:
6 years, 7 months ago by tdanderson

Modified:
6 years, 6 months ago

Reviewers:
sadrul

CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Introduce View::CanProcessEventsWithinSubtree() Introduce the virtual function View::CanProcessEventsWithinSubtree(), which returns true if the view and any of its descendants are permitted to be the target of an event. This will be called as part of event targeting and replaces the overrides of View::HitTestRect() in cases where the rect parameter is unused. One such replacement (for ImageView) is made in this CL. BUG=374325, 378530 TEST=ViewTest.CanProcessEventsWithinSubtree, ViewTargeterTest.CanProcessEventsWithinSubtree Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274011

Patch Set 1 #

Patch Set 2 : remove BookmarkBarView changes #

Patch Set 3 : one test added #

Patch Set 4 : second test added #

Total comments: 4

Patch Set 5 : comments addressed #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+282 lines, -5 lines)			Patch
M	ui/views/controls/image_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/image_view.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	ui/views/view.h	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/view.cc	View	1 2 3	3 chunks	+10 lines, -0 lines	0 comments	Download
M	ui/views/view_targeter.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/view_targeter_unittest.cc	View	1 2 3 4	2 chunks	+97 lines, -0 lines	0 comments	Download
M	ui/views/view_unittest.cc	View	1 2 3	5 chunks	+164 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sadrul

A couple of nits, other than that, LGTM https://codereview.chromium.org/297963006/diff/60001/ui/views/view_targeter_unittest.cc File ui/views/view_targeter_unittest.cc (right): https://codereview.chromium.org/297963006/diff/60001/ui/views/view_targeter_unittest.cc#newcode284 ui/views/view_targeter_unittest.cc:284: EXPECT_EQ(&v3, ...

6 years, 6 months ago (2014-05-30 21:20:34 UTC) #2

tdanderson

https://codereview.chromium.org/297963006/diff/60001/ui/views/view_targeter_unittest.cc File ui/views/view_targeter_unittest.cc (right): https://codereview.chromium.org/297963006/diff/60001/ui/views/view_targeter_unittest.cc#newcode284 ui/views/view_targeter_unittest.cc:284: EXPECT_EQ(&v3, static_cast<View*>(current_target)); On 2014/05/30 21:20:34, sadrul wrote: > I ...

6 years, 6 months ago (2014-05-30 21:41:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/297963006/80001

6 years, 6 months ago (2014-05-30 21:45:28 UTC) #5

Message was sent while issue was closed.

Change committed as 274011

Expand Messages | Collapse Messages