Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 297963004: Docserver: Update app version parsing since AppEngine started including / (Closed)

Created:
6 years, 7 months ago by not at google - send to devlin
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Docserver: Update app version parsing since AppEngine started including '/' separators. R=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272653

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
https://codereview.chromium.org/297963004/diff/1/chrome/common/extensions/docs/server2/app.yaml File chrome/common/extensions/docs/server2/app.yaml (right): https://codereview.chromium.org/297963004/diff/1/chrome/common/extensions/docs/server2/app.yaml#newcode2 chrome/common/extensions/docs/server2/app.yaml:2: version: 3-23-1 bumped to 3-23-1 because the running server ...
6 years, 7 months ago (2014-05-23 19:14:29 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 7 months ago (2014-05-23 20:51:56 UTC) #2
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-05-23 20:52:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/297963004/20001
6 years, 7 months ago (2014-05-23 20:52:59 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 00:28:24 UTC) #5
Message was sent while issue was closed. 
Change committed as 272653

Powered by Google App Engine
This is Rietveld 408576698