pkg/front_end/lib/src/fasta/problems.dart - Issue 2979623002: Use messages for (some) public API errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/problems.dart

Issue 2979623002: Use messages for (some) public API errors (Closed)

Patch Set: cl comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/front_end/lib/src/fasta/problems.dart

diff --git a/pkg/front_end/lib/src/fasta/problems.dart b/pkg/front_end/lib/src/fasta/problems.dart

index 4a3098bf291864dc05fa1b69073d0b358a11d589..26b34233ece93de135e939555334b525553d8d5d 100644

--- a/pkg/front_end/lib/src/fasta/problems.dart

+++ b/pkg/front_end/lib/src/fasta/problems.dart

@@ -34,7 +34,7 @@ dynamic internalProblem(Message message, int charOffset, Uri uri) {

}

-dynamic unimplemented(String what, int charOffset, Uri uri) {

+dynamic unimplemented(String what, [int charOffset = -1, Uri uri = null]) {

return internalProblem(

templateInternalProblemUnimplemented.withArguments(what),

charOffset,