Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: pkg/front_end/lib/compilation_error.dart

Issue 2979623002: Use messages for (some) public API errors (Closed)
Patch Set: cl comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/compilation_error.dart
diff --git a/pkg/front_end/lib/compilation_error.dart b/pkg/front_end/lib/compilation_error.dart
index 5e30da1c730cc5c961d11cc81b8610f704e4887c..e78e8f91a8e8cd7568880fb3ae947105d7609f47 100644
--- a/pkg/front_end/lib/compilation_error.dart
+++ b/pkg/front_end/lib/compilation_error.dart
@@ -9,18 +9,20 @@ library front_end.compilation_error;
import 'package:source_span/source_span.dart' show SourceSpan;
/// A single error that occurred during compilation, and information about where
-/// it occurred.
+/// it occurred and how to fix it.
///
/// TODO(paulberry): add a reference to the analyzer error code.
///
/// Not intended to be implemented or extended by clients.
+// TODO(sigmund): rename to CompliationMessage
abstract class CompilationError {
- /// A text description of how the user can fix the error. May be `null`.
- String get correction;
+ /// A text description of the compile error.
+ String get message;
+
+ /// A suggestion for the user to hint them on how to fix the error. May be
+ /// `null`.
+ String get tip;
/// The source span where the error occurred.
SourceSpan get span;
-
- /// A text description of the compile error.
- String get message;
}
« no previous file with comments | « no previous file | pkg/front_end/lib/kernel_generator.dart » ('j') | pkg/front_end/lib/src/base/processed_options.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698