Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Side by Side Diff: pkg/front_end/test/subpackage_relationships_test.dart

Issue 2979623002: Use messages for (some) public API errors (Closed)
Patch Set: wrap - verification error still pending Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:io'; 6 import 'dart:io';
7 7
8 import 'package:front_end/compiler_options.dart'; 8 import 'package:front_end/compiler_options.dart';
9 import 'package:front_end/dependency_grapher.dart'; 9 import 'package:front_end/dependency_grapher.dart';
10 import 'package:path/path.dart' as pathos; 10 import 'package:path/path.dart' as pathos;
(...skipping 23 matching lines...) Expand all
34 /// 34 ///
35 /// Each listed directory is considered a subpackage. Each package contains all 35 /// Each listed directory is considered a subpackage. Each package contains all
36 /// of its descendant files that are not in a more deeply nested subpackage. 36 /// of its descendant files that are not in a more deeply nested subpackage.
37 /// 37 ///
38 /// TODO(paulberry): stuff in lib/src shouldn't depend on lib; lib should just 38 /// TODO(paulberry): stuff in lib/src shouldn't depend on lib; lib should just
39 /// re-export stuff in lib/src. 39 /// re-export stuff in lib/src.
40 final subpackageRules = { 40 final subpackageRules = {
41 'lib': new SubpackageRules(allowedDependencies: [ 41 'lib': new SubpackageRules(allowedDependencies: [
42 'lib/src', 42 'lib/src',
43 'lib/src/base', 43 'lib/src/base',
44 'lib/src/fasta',
44 'lib/src/incremental', 45 'lib/src/incremental',
45 ]), 46 ]),
46 'lib/src': new SubpackageRules(allowedDependencies: [ 47 'lib/src': new SubpackageRules(allowedDependencies: [
47 'lib', 48 'lib',
48 'lib/src/base', 49 'lib/src/base',
49 'lib/src/fasta', 50 'lib/src/fasta',
50 "lib/src/fasta/dill", 51 "lib/src/fasta/dill",
51 "lib/src/fasta/kernel", 52 "lib/src/fasta/kernel",
52 'lib/src/fasta/source', 53 'lib/src/fasta/source',
53 'lib/src/incremental', 54 'lib/src/incremental',
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 if (subpackageRules[subpackage].allowSubdirs) { 315 if (subpackageRules[subpackage].allowSubdirs) {
315 subpackageRules[subpackage].actuallyHasSubdirs = true; 316 subpackageRules[subpackage].actuallyHasSubdirs = true;
316 } else { 317 } else {
317 problem('Uri $src is in a subfolder of $subpackage, but that ' 318 problem('Uri $src is in a subfolder of $subpackage, but that '
318 'subpackage does not allow dart files in subdirectories.'); 319 'subpackage does not allow dart files in subdirectories.');
319 } 320 }
320 } 321 }
321 return subpackage; 322 return subpackage;
322 } 323 }
323 } 324 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698