Use messages for (some) public API errors

pkg/front_end/lib/src/base/processed_options.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:front_end/compilation_error.dart';
 import 'package:front_end/compiler_options.dart';
 import 'package:front_end/file_system.dart';
 import 'package:front_end/src/base/performace_logger.dart';
+import 'package:front_end/src/fasta/fasta_codes.dart';
 import 'package:front_end/src/fasta/ticker.dart';
 import 'package:front_end/src/fasta/translate_uri.dart';
 import 'package:front_end/src/incremental/byte_store.dart';
 import 'package:front_end/src/multi_root_file_system.dart';
 import 'package:kernel/kernel.dart'
     show Program, loadProgramFromBytes, CanonicalName;
 import 'package:kernel/target/targets.dart';
 import 'package:kernel/target/vm_fasta.dart';
 import 'package:package_config/packages_file.dart' as package_config;
-import 'package:source_span/source_span.dart' show SourceSpan;
+import 'package:source_span/source_span.dart' show SourceSpan, SourceLocation;
 
 /// All options needed for the front end implementation.
 ///
 /// This includes: all of [CompilerOptions] in a form useful to the
 /// implementation, default values for options that were not provided,
 /// and information derived from how the compiler was invoked (like the
 /// entry-points given to the compiler and whether a modular or whole-program
 /// API was used).
 ///
 /// The intent is that the front end should immediately wrap any incoming
@@ skipping 70 matching lines @@
   /// The logger to report compilation progress.
   PerformanceLog get logger {
     return _raw.logger;
   }
 
   /// The byte storage to get and put serialized data.
   ByteStore get byteStore {
     return _raw.byteStore;
   }
 
-  // TODO(sigmund): delete. We should use messages with error codes directly
-  // instead.
-  void reportError(String message) {
-    _raw.onError(new _CompilationError(message));
+  void reportMessage(LocatedMessage message) {
+    _raw.onError(new _CompilationMessage(message));
   }
 
+  void reportMessageNoLocation(Message message) =>
+      reportMessage(message.withLocation(null, -1));
+
   /// Runs various validations checks on the input options. For instance,
   /// if an option is a path to a file, it checks that the file exists.
   Future<bool> validateOptions() async {
     for (var source in inputs) {
       if (source.scheme == 'file' &&
           !await fileSystem.entityForUri(source).exists()) {
-        reportError("Entry-point file not found: $source");
+        reportMessageNoLocation(
+            templateMissingInputFile.withArguments('$source'));
         return false;
       }
     }
 
     if (_raw.sdkRoot != null &&
         !await fileSystem.entityForUri(sdkRoot).exists()) {
-      reportError("SDK root directory not found: ${sdkRoot}");
+      reportMessageNoLocation(templateMissingSdkRoot.withArguments('$sdkRoot'));
       return false;
     }
 
     var summary = sdkSummary;
     if (summary != null && !await fileSystem.entityForUri(summary).exists()) {
-      reportError("SDK summary not found: ${summary}");
+      reportMessageNoLocation(
+          templateMissingSdkSummary.withArguments('$summary'));
       return false;
     }
 
     if (compileSdk && summary != null) {
-      reportError(
-          "The compileSdk and sdkSummary options are mutually exclusive");
+      reportMessageNoLocation(templateUnsupported.withArguments(
+          "The compileSdk and sdkSummary options are mutually exclusive"));
       return false;
     }
     return true;
   }
 
   /// Determine whether to generate code for the SDK when compiling a
   /// whole-program.
   bool get compileSdk => _raw.compileSdk;
 
   FileSystem _fileSystem;
@@ skipping 183 matching lines @@
       : super(
             uri,
             'Invalid access to $uri: '
             'the file is accessed in a modular hermetic build, '
             'but it was not explicitly listed as an input.');
 
   @override
   String toString() => message;
 }
 
-/// An error that only contains a message and no error location.
-class _CompilationError implements CompilationError {
-  String get correction => null;
-  SourceSpan get span => null;
-  final String message;
-  _CompilationError(this.message);
+/// Wraps a [LocatedMessage] to implement the public [CompilationError] API.
+class _CompilationMessage implements CompilationError {
+  final LocatedMessage original;
+
+  String get message => original.message;
+
+  String get tip => original.tip;
+
+  SourceSpan get span =>
+      new SourceLocation(original.charOffset, sourceUrl: original.uri)
+          .pointSpan();
+
+  _CompilationMessage(this.original);
 
   String toString() => message;
 }