Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2979613002: Treat JS TypeError as Dart NSM (Closed)

Created:
3 years, 5 months ago by vsm
Modified:
3 years, 5 months ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 5 chunks +0 lines, -5 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_helper.dart View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 5 months ago (2017-07-11 00:57:05 UTC) #3
Jacob
lgtm
3 years, 5 months ago (2017-07-11 05:21:14 UTC) #4
vsm
3 years, 5 months ago (2017-07-11 12:44:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b742853c7d1c8c6cbd3c53714626a938d2fef13 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698