Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2979463002: Revert "Tweak public APIs and use them in patch_sdk, dart2js, and kernel-service." (Closed)

Created:
3 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 5 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, turnidge, rmacnak, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Tweak public APIs and use them in patch_sdk, dart2js, and kernel-service." Reason: broke VM bots, still investigating. This reverts commit 610d0819477c5bb0ede1d9f219c50e91e5994afa. TBR= paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/4aadfe09df6c2cff33b2850cbfc42c9806ed31b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1301 lines, -1965 lines) Patch
D pkg/compiler/lib/src/kernel/dart2js_target.dart View 1 chunk +0 lines, -92 lines 0 comments Download
A pkg/compiler/lib/src/kernel/fasta_support.dart View 1 chunk +201 lines, -0 lines 0 comments Download
M pkg/compiler/tool/generate_kernel.dart View 1 chunk +24 lines, -46 lines 0 comments Download
M pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/compiler_options.dart View 4 chunks +56 lines, -103 lines 0 comments Download
D pkg/front_end/lib/front_end.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/front_end/lib/kernel_generator.dart View 3 chunks +135 lines, -32 lines 0 comments Download
M pkg/front_end/lib/src/base/processed_options.dart View 8 chunks +42 lines, -208 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/compile_platform.dart View 2 chunks +34 lines, -27 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta.dart View 5 chunks +79 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 4 chunks +2 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 6 chunks +86 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/utils.dart View 2 chunks +0 lines, -24 lines 0 comments Download
M pkg/front_end/lib/src/fasta/loader.dart View 1 chunk +0 lines, -3 lines 0 comments Download
A pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart View 1 chunk +56 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/lib/src/fasta/parser/native_support.dart View 1 chunk +0 lines, -86 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 5 chunks +4 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 5 chunks +6 lines, -11 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 2 chunks +9 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/target_implementation.dart View 2 chunks +25 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/kernel_chain.dart View 2 chunks +1 line, -39 lines 0 comments Download
A pkg/front_end/lib/src/fasta/vm.dart View 1 chunk +165 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 4 chunks +19 lines, -3 lines 0 comments Download
D pkg/front_end/lib/src/kernel_generator_impl.dart View 1 chunk +0 lines, -171 lines 0 comments Download
A pkg/front_end/lib/src/simple_error.dart View 1 chunk +11 lines, -0 lines 0 comments Download
D pkg/front_end/lib/src/testing/compiler_common.dart View 1 chunk +0 lines, -123 lines 0 comments Download
M pkg/front_end/lib/summary_generator.dart View 2 chunks +7 lines, -18 lines 0 comments Download
M pkg/front_end/test/fasta/shaker_test.dart View 5 chunks +30 lines, -12 lines 0 comments Download
M pkg/front_end/test/fasta/testing/suite.dart View 3 chunks +9 lines, -6 lines 0 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 2 chunks +6 lines, -3 lines 0 comments Download
D pkg/front_end/test/kernel_generator_test.dart View 1 chunk +0 lines, -210 lines 0 comments Download
M pkg/front_end/test/src/base/processed_options_test.dart View 4 chunks +2 lines, -111 lines 0 comments Download
M pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 4 chunks +10 lines, -7 lines 0 comments Download
D pkg/front_end/test/summary_generator_test.dart View 1 chunk +0 lines, -152 lines 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 7 chunks +36 lines, -23 lines 0 comments Download
M pkg/front_end/tool/perf.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 4 chunks +9 lines, -32 lines 0 comments Download
M pkg/kernel/lib/binary/limited_ast_to_binary.dart View 2 chunks +1 line, -24 lines 0 comments Download
M pkg/kernel/lib/target/targets.dart View 1 chunk +0 lines, -23 lines 0 comments Download
M pkg/kernel/lib/target/vm.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/kernel/test/closures/suite.dart View 4 chunks +73 lines, -13 lines 0 comments Download
M pkg/kernel/test/interpreter/suite.dart View 1 chunk +72 lines, -7 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -2 lines 0 comments Download
A runtime/bin/vmservice_sdk/lib/libraries.json View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/dill_loader_test.dart View 3 chunks +17 lines, -21 lines 0 comments Download
M tools/patch_sdk.dart View 4 chunks +45 lines, -104 lines 0 comments Download
M utils/kernel-service/kernel-service.dart View 3 chunks +7 lines, -162 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 4aadfe09df6c2cff33b2850cbfc42c9806ed31b1 (presubmit successful).
3 years, 5 months ago (2017-07-07 22:21:44 UTC) #2
Paul Berry
3 years, 5 months ago (2017-07-10 15:28:06 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698