Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2979403002: Update checked-in d8 shell to version 6.2.0 (Closed)

Created:
3 years, 5 months ago by Bill Hesse
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom, sortie, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update checked-in d8 shell to version 6.2.0 BUG=https://github.com/dart-lang/sdk/issues/29794 R=rnystrom@google.com, sra@google.com Committed: https://github.com/dart-lang/sdk/commit/cbaaceca2f95ebb370cfbeedacbfa65607f82dac

Patch Set 1 #

Patch Set 2 : Add ARM32 D8 6.1.0 #

Patch Set 3 : Add x64 and ARM64 versions of d8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -14 lines) Patch
M sdk/lib/_internal/js_runtime/lib/preambles/d8.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tests/lib/lib.status View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/d8/README.google View 1 1 chunk +10 lines, -6 lines 0 comments Download
A third_party/d8/linux/arm32/d8.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/arm32/natives_blob.bin.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/arm32/snapshot_blob.bin.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/arm64/d8.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/arm64/natives_blob.bin.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/arm64/snapshot_blob.bin.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/d8/linux/d8.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/d8/linux/d8-arm.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
A third_party/d8/linux/ia32/d8.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/ia32/natives_blob.bin.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/ia32/snapshot_blob.bin.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/natives_blob.bin.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/snapshot_blob.bin.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/x64/d8.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/x64/natives_blob.bin.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/x64/snapshot_blob.bin.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/d8/macos/d8.sha1 View 1 chunk +1 line, -1 line 0 comments Download
A third_party/d8/macos/natives_blob.bin.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/macos/snapshot_blob.bin.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/d8/windows/d8.exe.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/d8/windows/natives_blob.bin.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/windows/snapshot_blob.bin.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Bill Hesse
TBR=sra@google.com Reverts the revert of roll D8, adds MacOS and ARM32 d8 shells.
3 years, 5 months ago (2017-07-21 12:09:28 UTC) #2
sra1
lgtm, other than the title "6.2.0" -> "6.1.0"
3 years, 5 months ago (2017-07-21 17:18:20 UTC) #5
Bob Nystrom
lgtm
3 years, 5 months ago (2017-07-21 17:33:14 UTC) #6
sortie
The linux directory contains a top level ia32 d8 for compatibility? Is that meant to ...
3 years, 5 months ago (2017-07-24 22:14:10 UTC) #7
sortie
The linux/arm64 directory does not contain a Linux arm64 build. The executable uses the dynamic ...
3 years, 5 months ago (2017-07-24 23:12:24 UTC) #8
Bill Hesse
On 2017/07/24 23:12:24, sortie wrote: > The linux/arm64 directory does not contain a Linux arm64 ...
3 years, 4 months ago (2017-07-26 12:01:37 UTC) #9
Bob Nystrom
lgtm
3 years, 4 months ago (2017-07-26 17:15:05 UTC) #10
sortie
The 6.2.0 builds works for me. arm64 still needs to become a Linux build, or ...
3 years, 4 months ago (2017-07-26 20:06:46 UTC) #11
Bill Hesse
3 years, 4 months ago (2017-07-27 08:36:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
cbaaceca2f95ebb370cfbeedacbfa65607f82dac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698