Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/regexp_helper.dart

Issue 2979353002: implement `Invocation.typeArguments` in DDC (Closed)
Patch Set: fix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/dev_compiler/tool/input_sdk/private/js_array.dart ('K') | « pkg/dev_compiler/tool/input_sdk/private/js_array.dart ('k') | tests/language_strong/invocation_mirror2_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/tool/input_sdk/private/regexp_helper.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/private/regexp_helper.dart b/pkg/dev_compiler/tool/input_sdk/private/regexp_helper.dart
index fdfd0d9bb0f359b44bc973b7af85c725e57e47d7..efcea7c971a0d1f046cc863af4cd9b736eaa32ad 100644
--- a/pkg/dev_compiler/tool/input_sdk/private/regexp_helper.dart
+++ b/pkg/dev_compiler/tool/input_sdk/private/regexp_helper.dart
@@ -7,8 +7,7 @@ part of dart._js_helper;
// Helper method used by internal libraries.
regExpGetNative(JSSyntaxRegExp regexp) => regexp._nativeRegExp;
-List<String> _stringList(List l) =>
- l == null ? l : JS('', 'dart.list(#, #)', l, String);
+List<String> _stringList(List l) => l == null ? l : new JSArray<String>.of(l);
/**
* Returns a native version of the RegExp with the global flag set.
« pkg/dev_compiler/tool/input_sdk/private/js_array.dart ('K') | « pkg/dev_compiler/tool/input_sdk/private/js_array.dart ('k') | tests/language_strong/invocation_mirror2_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698