Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_common.dart

Issue 2979303002: Resynthesize binary, prefix, and conditional expressions from Kernel. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/resynthesize_common.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_common.dart b/pkg/analyzer/test/src/summary/resynthesize_common.dart
index 92d9b20eef58b339bf2b3111c038952227c10d2e..72f79f6c146210b77679693208905030e01b3e0f 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_common.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_common.dart
@@ -4653,12 +4653,21 @@ const vNegate = -1;
const vComplement = ~1;
''');
if (isStrongMode) {
- checkElementText(library, r'''
+ if (isSharedFrontEnd) {
+ checkElementText(library, r'''
+const bool vNotEqual = !1 == 2;
Paul Berry 2017/07/19 17:43:31 There's a precedence error here. It should be: c
scheglov 2017/07/19 19:35:15 Done.
+const bool vNot = !true;
+const int vNegate = -1;
+const int vComplement = ~1;
+''');
+ } else {
+ checkElementText(library, r'''
const bool vNotEqual = 1 != 2;
const bool vNot = !true;
const int vNegate = -1;
const int vComplement = ~1;
''');
+ }
} else {
checkElementText(library, r'''
const dynamic vNotEqual = 1 != 2;
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698