Resynthesize binary, prefix, and conditional expressions from Kernel.

Resynthesize binary, prefix, and conditional expressions from Kernel.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/3a4c33cc93ceb8128f5082deaa19fb1e0f9e6fbc

[Paul Berry, 2017-07-19 17:43:31]

https://codereview.chromium.org/2979303002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_common.dart (right):

https://codereview.chromium.org/2979303002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_common.dart:4658: const bool
vNotEqual = !1 == 2;
There's a precedence error here.  It should be:

const bool vNotEqual = !(1 == 2);

Can we change _ElementWriter.writeExpression() to account for precedence and
insert parentheses when appropriate?

Alternatively, we could just make _ElementWriter.writeExpression() parenthesize
all subexpressions, since it's just used for test expectations and isn't user
facing.

[scheglov, 2017-07-19 19:35:15]

PTAL

https://codereview.chromium.org/2979303002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_common.dart (right):

https://codereview.chromium.org/2979303002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_common.dart:4658: const bool
vNotEqual = !1 == 2;
On 2017/07/19 17:43:31, Paul Berry wrote:
> There's a precedence error here.  It should be:
> 
> const bool vNotEqual = !(1 == 2);
> 
> Can we change _ElementWriter.writeExpression() to account for precedence and
> insert parentheses when appropriate?
> 
> Alternatively, we could just make _ElementWriter.writeExpression()
parenthesize
> all subexpressions, since it's just used for test expectations and isn't user
> facing.

Done.

[Paul Berry, 2017-07-19 19:35:54]

lgtm

[scheglov, 2017-07-19 19:36:54]

Description was changed from

==========
Resynthesize binary, prefix, and conditional expressions from Kernel.

R=paulberry@google.com
BUG=
==========

to

==========
Resynthesize binary, prefix, and conditional expressions from Kernel.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/3a4c33cc93ceb8128f5082deaa19fb1e0f9e6fbc
==========

[scheglov, 2017-07-19 19:36:55]

Committed patchset #2 (id:20001) manually as
3a4c33cc93ceb8128f5082deaa19fb1e0f9e6fbc (presubmit successful).