Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: common/proto/milo/annotations.proto

Issue 2979283002: Add manifest links and hack to index on revision. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | common/proto/milo/annotations.pb.go » ('j') | milo/api/resp/build.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: common/proto/milo/annotations.proto
diff --git a/common/proto/milo/annotations.proto b/common/proto/milo/annotations.proto
index a77a82f0f0dca6e7c4b5c97c2ddf18dd3141d2aa..3df0e01d6b99558912df883e3b2eff8cd0845285 100644
--- a/common/proto/milo/annotations.proto
+++ b/common/proto/milo/annotations.proto
@@ -137,6 +137,26 @@ message Step {
string value = 2;
}
repeated Property property = 24;
+
+ // Links to a recipe_engine.Manifest proto.
+ message ManifestLink {
+ // The fully qualified (logdog://) url of the Manifest proto. It's expected
+ // that this is a binary logdog stream consisting of exactly one Manifest
+ // proto.
+ string url = 1;
+
+ // The hash of the Manifest. Milo will use this as an optimization;
Ryan Tseng 2017/07/19 00:29:38 "The hash of the content of the Manifest in binary
iannucci 2017/07/19 00:38:16 Done.
+ // Manifests will be interned once into Milo's datastore. Future hashes
+ // which match will not be loaded from the url, but will be assumed to be
+ // identical. If the sha256 doesn't match the data at the URL, Milo may
+ // render this build with the wrong manifest.
+ string sha256 = 2;
+ }
+
+ // Maps the name of the Manifest, e.g. UNPATCHED, INFRA, etc. to the
+ // ManifestLink. This name will be used in the milo console definition to
+ // indicate which manifest data to sort the console view by.
+ map<string, ManifestLink> source_manifests = 25;
}
// A Link is an optional label followed by a typed link to an external
« no previous file with comments | « no previous file | common/proto/milo/annotations.pb.go » ('j') | milo/api/resp/build.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698