Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: runtime/vm/message_handler.h

Issue 2979243002: Remove some pause-related fields in a PRODUCT build (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/message_handler.h
diff --git a/runtime/vm/message_handler.h b/runtime/vm/message_handler.h
index 88942edf4567e72e1588fdd32de83d1460b179e0..d34b05b8c3ebd31db8d1ccb29a35420aa34a8c32 100644
--- a/runtime/vm/message_handler.h
+++ b/runtime/vm/message_handler.h
@@ -79,8 +79,6 @@ class MessageHandler {
intptr_t live_ports() const { return live_ports_; }
- void DebugDump();
-
bool paused() const { return paused_ > 0; }
void increment_paused() { paused_++; }
@@ -89,7 +87,9 @@ class MessageHandler {
paused_--;
}
- bool ShouldPauseOnStart(MessageStatus status) const;
+#if !defined(PRODUCT)
+ void DebugDump();
+
bool should_pause_on_start() const { return should_pause_on_start_; }
void set_should_pause_on_start(bool should_pause_on_start) {
@@ -98,7 +98,6 @@ class MessageHandler {
bool is_paused_on_start() const { return is_paused_on_start_; }
- bool ShouldPauseOnExit(MessageStatus status) const;
bool should_pause_on_exit() const { return should_pause_on_exit_; }
void set_should_pause_on_exit(bool should_pause_on_exit) {
@@ -110,8 +109,11 @@ class MessageHandler {
// Timestamp of the paused on start or paused on exit.
int64_t paused_timestamp() const { return paused_timestamp_; }
+ bool ShouldPauseOnStart(MessageStatus status) const;
+ bool ShouldPauseOnExit(MessageStatus status) const;
void PausedOnStart(bool paused);
void PausedOnExit(bool paused);
+#endif
// Gives temporary ownership of |queue| and |oob_queue|. Using this object
// has the side effect that no OOB messages will be handled if a stack
@@ -232,12 +234,14 @@ class MessageHandler {
bool oob_message_handling_allowed_;
intptr_t live_ports_; // The number of open ports, including control ports.
intptr_t paused_; // The number of pause messages received.
+#if !defined(PRODUCT)
bool should_pause_on_start_;
bool should_pause_on_exit_;
bool is_paused_on_start_;
bool is_paused_on_exit_;
- bool delete_me_;
int64_t paused_timestamp_;
+#endif
+ bool delete_me_;
ThreadPool* pool_;
ThreadPool::Task* task_;
StartCallback start_callback_;
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/message_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698