Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: runtime/vm/isolate.h

Issue 2979243002: Remove some pause-related fields in a PRODUCT build (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index 6afe1b2f2c85ea76c8617e30083f10727fd0dfa2..ff26b4eb38df7b75d79a9c0a0c425fccca2da04e 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -301,9 +301,11 @@ class Isolate : public BaseIsolate {
bool is_runnable() const { return is_runnable_; }
void set_is_runnable(bool value) {
is_runnable_ = value;
+#if !defined(PRODUCT)
if (is_runnable_) {
set_last_resume_timestamp();
}
+#endif
}
IsolateSpawnState* spawn_state() const { return spawn_state_; }
@@ -332,6 +334,7 @@ class Isolate : public BaseIsolate {
return OFFSET_OF(Isolate, single_step_);
}
+#if !defined(PRODUCT)
// Lets the embedder know that a service message resulted in a resume request.
void SetResumeRequest() {
resume_request_ = true;
@@ -351,6 +354,7 @@ class Isolate : public BaseIsolate {
resume_request_ = false;
return resume_request;
}
+#endif
// Verify that the sender has the capability to pause or terminate the
// isolate.
@@ -631,8 +635,10 @@ class Isolate : public BaseIsolate {
static void VisitIsolates(IsolateVisitor* visitor);
+#if !defined(PRODUCT)
// Handle service messages until we are told to resume execution.
void PauseEventHandler();
+#endif
void AddClosureFunction(const Function& function) const;
RawFunction* LookupClosureFunction(const Function& parent,
@@ -766,8 +772,8 @@ class Isolate : public BaseIsolate {
Dart_LibraryTagHandler library_tag_handler_;
ApiState* api_state_;
NOT_IN_PRODUCT(Debugger* debugger_);
- bool resume_request_;
- int64_t last_resume_timestamp_;
+ NOT_IN_PRODUCT(bool resume_request_);
+ NOT_IN_PRODUCT(int64_t last_resume_timestamp_);
Random random_;
Simulator* simulator_;
Mutex* mutex_; // Protects compiler stats.
@@ -881,7 +887,9 @@ class Isolate : public BaseIsolate {
static Dart_IsolateShutdownCallback shutdown_callback_;
static Dart_IsolateCleanupCallback cleanup_callback_;
+#if !defined(PRODUCT)
static void WakePauseEventHandler(Dart_Isolate isolate);
+#endif
// Manage list of existing isolates.
static bool AddIsolateToList(Isolate* isolate);
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698