Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: Source/devtools/front_end/sdk/SASSSourceMapping.js

Issue 297923002: DevTools: Decouple CSS model from UI entities (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase atop new workspace bindings Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/SASSSourceMapping.js
diff --git a/Source/devtools/front_end/sdk/SASSSourceMapping.js b/Source/devtools/front_end/sdk/SASSSourceMapping.js
index a48335a610ddc770653c1a76f6fa4cc3140a8ae3..6f0d4b91091720139f22636d614ec6fe04226810 100644
--- a/Source/devtools/front_end/sdk/SASSSourceMapping.js
+++ b/Source/devtools/front_end/sdk/SASSSourceMapping.js
@@ -419,7 +419,7 @@ WebInspector.SASSSourceMapping.prototype = {
var completeSourceMapURL = WebInspector.ParsedURL.completeURL(sourceURL, header.sourceMapURL);
if (completeSourceMapURL)
delete this._sourceMapByURL[completeSourceMapURL];
- header.updateLocations();
+ WebInspector.cssWorkspaceBinding.updateLocations(header);
},
/**
@@ -445,7 +445,7 @@ WebInspector.SASSSourceMapping.prototype = {
this._sourceMapByStyleSheetURL[sourceURL] = sourceMap;
for (var i = 0; i < headersWithSameSourceURL.length; ++i) {
if (forceRebind)
- headersWithSameSourceURL[i].updateLocations();
+ WebInspector.cssWorkspaceBinding.updateLocations(headersWithSameSourceURL[i]);
else
this._bindUISourceCode(headersWithSameSourceURL[i], sourceMap);
}
@@ -519,7 +519,7 @@ WebInspector.SASSSourceMapping.prototype = {
*/
_bindUISourceCode: function(header, sourceMap)
{
- header.pushSourceMapping(this);
+ WebInspector.cssWorkspaceBinding.pushSourceMapping(header, this);
var rawURL = header.sourceURL;
var sources = sourceMap.sources();
for (var i = 0; i < sources.length; ++i) {
@@ -603,8 +603,9 @@ WebInspector.SASSSourceMapping.prototype = {
var ids = this._cssModel.styleSheetIdsForURL(cssURLs[i]);
for (var j = 0; j < ids.length; ++j) {
var header = this._cssModel.styleSheetHeaderForId(ids[j]);
- console.assert(header);
- header.updateLocations();
+ if (!header)
+ throw new Error("Header not found for id=" + ids[j]);
vsevik 2014/07/22 14:59:01 This should never happen and we used to assert in
apavlov 2014/07/22 16:19:53 Done.
+ WebInspector.cssWorkspaceBinding.updateLocations(header);
}
}
},

Powered by Google App Engine
This is Rietveld 408576698