Allow setting breakpoints in function literal field initializers under --dfe.

runtime/vm/kernel_to_il.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <set>
 
 #include "vm/kernel_to_il.h"
 
 #include "vm/compiler.h"
 #include "vm/intermediate_language.h"
@@ skipping 58 matching lines @@
 
 TranslationHelper::TranslationHelper(Thread* thread)
     : thread_(thread),
       zone_(thread->zone()),
       isolate_(thread->isolate()),
       allocation_space_(thread->IsMutatorThread() ? Heap::kNew : Heap::kOld),
       string_offsets_(TypedData::Handle(Z)),
       string_data_(TypedData::Handle(Z)),
       canonical_names_(TypedData::Handle(Z)) {}
 
+TranslationHelper::TranslationHelper(Thread* thread,
+                                     dart::RawTypedData* string_offsets,
+                                     dart::RawTypedData* string_data,
+                                     dart::RawTypedData* canonical_names)
+    : thread_(thread),
+      zone_(thread->zone()),
+      isolate_(thread->isolate()),
+      allocation_space_(thread->IsMutatorThread() ? Heap::kNew : Heap::kOld),

[siva, 2017/07/17 22:39:23]

When does this constructor run on a non Mutator thread?

[sivachandra, 2017/07/17 23:49:36]

Per my limited knowledge, the use case added by this change does not run on a
non-mutator thread. However, I just copied this part from the above constructor
to be consistent.

[siva, 2017/07/18 22:49:06]

True but that was because this code could be executed by the background
compiler, but in your case we should not be ever executing it from anything but
the mutator thread, maybe you could add and assert in the constructor
ASSERT(thread->IsMutatorThread());

[sivachandra, 2017/07/19 00:14:21]

Done.

+      string_offsets_(TypedData::Handle(Z, string_offsets)),
+      string_data_(TypedData::Handle(Z, string_data)),
+      canonical_names_(TypedData::Handle(Z, canonical_names)) {}
+
 void TranslationHelper::SetStringOffsets(const TypedData& string_offsets) {
   ASSERT(string_offsets_.IsNull());
   string_offsets_ = string_offsets.raw();
 }
 
 void TranslationHelper::SetStringData(const TypedData& string_data) {
   ASSERT(string_data_.IsNull());
   string_data_ = string_data.raw();
 }
 
@@ skipping 2248 matching lines @@
   StreamingFlowGraphBuilder streaming_flow_graph_builder(
       &helper, zone_, script.kernel_data(), script.kernel_data_size());
   return streaming_flow_graph_builder.GetLineStartsFor(
       script.kernel_script_index());
 }
 
 }  // namespace kernel
 }  // namespace dart
 
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)