Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2979073002: "Set up directories.." commit below broke the buildbot tests, two others are collateral damage. (Closed)

Created:
3 years, 5 months ago by aam
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom, jcollins, zra
CC:
reviews_dartlang.org, zra
Target Ref:
refs/heads/master
Visibility:
Public.

Description

"Set up directories.." commit below broke the buildbot tests, two others are collateral damage. Revert "Precompiler doesn't report Dart 2.0 static type errors yet." This reverts commit 7af2d86ed3cacec955171311e3660a54bf26a574. Revert "Move absstract_exact_selector back into the language tests. (#30169)" This reverts commit 452d2d08402d5521ae2d09cd29d2c8147ac1cab2. Revert "Set up directories for migrated Dart 2.0 tests and migrate a couple. (#30149)" This reverts commit 47985d6dbd85c541eb0374d95addf677af51ae5f. R=zra@google.com BUG:dartbug.com/30171 Committed: https://github.com/dart-lang/sdk/commit/9882d494db32026d05620bdbba410993ba4de83b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -290 lines) Patch
A + tests/compiler/dart2js/compiler_annotations.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib/apply_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/corelib_2/apply_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
D tests/corelib_2/corelib_2.status View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/corelib_2/symbol_map_helper.dart View 1 chunk +0 lines, -15 lines 0 comments Download
A + tests/corelib_strong/apply_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/aborting_switch_case_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language/abstract_beats_arguments2_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A tests/language/abstract_beats_arguments_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A + tests/language/abstract_exact_selector_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language/abstract_getter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/language_2/aborting_switch_case_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/language_2/abstract_beats_arguments_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/language_2/abstract_exact_selector_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/language_2/abstract_getter_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/language_2/compiler_annotations.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/language_2/language_2.status View 1 chunk +0 lines, -9 lines 0 comments Download
A + tests/language_strong/aborting_switch_case_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/abstract_exact_selector_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language_strong/abstract_getter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/math/call_cmath_box_failure_path_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/lib_2/lib_2.status View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/lib_2/math/call_cmath_box_failure_path_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
M tools/bots/ddc_tests.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/testing/dart/options.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -26 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
aam
3 years, 5 months ago (2017-07-14 21:31:02 UTC) #3
zra
lgtm
3 years, 5 months ago (2017-07-14 21:42:38 UTC) #6
aam
3 years, 5 months ago (2017-07-14 21:44:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9882d494db32026d05620bdbba410993ba4de83b.

Powered by Google App Engine
This is Rietveld 408576698