Issue 2979053002: simplify and remove unnecessary checks in kernel service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2979053002: simplify and remove unnecessary checks in kernel service (Closed)

Created:
3 years, 5 months ago by Siggi Cherem (dart-lang)

Modified:
3 years, 5 months ago

Reviewers:
ahe, siva

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

simplify and remove unnecessary checks in kernel service Checks here should also be handled internally by the front-end, so no need to do them twice. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/2465864241cf891dc1901daa57c8723008ca3e14

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -78 lines)			Patch
	M	utils/kernel-service/kernel-service.dart	View	1	2 chunks	+45 lines, -78 lines	0 comments	Download

Total messages: 6 (3 generated)

Siggi Cherem (dart-lang)

3 years, 5 months ago (2017-07-17 22:31:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:40001) manually as
2465864241cf891dc1901daa57c8723008ca3e14 (presubmit successful).