Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 297903005: Update chromium-side ServiceWorker directory owners (Closed)

Created:
6 years, 7 months ago by kinuko
Modified:
6 years, 7 months ago
Reviewers:
michaeln, falken, nhiroki, horo
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

Update chromium-side ServiceWorker directory owners BUG=n/a NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272717

Patch Set 1 #

Patch Set 2 : added internals related ones #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M content/browser/resources/service_worker/OWNERS View 1 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/service_worker/OWNERS View 1 1 chunk +11 lines, -2 lines 0 comments Download
M content/child/service_worker/OWNERS View 1 chunk +4 lines, -2 lines 0 comments Download
M content/common/service_worker/OWNERS View 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/service_worker/OWNERS View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
kinuko
PTL
6 years, 7 months ago (2014-05-23 13:28:32 UTC) #1
horo
On 2014/05/23 13:28:32, kinuko wrote: > PTL Could you please add me to the OWNERs ...
6 years, 7 months ago (2014-05-23 14:15:19 UTC) #2
kinuko
On 2014/05/23 14:15:19, horo wrote: > On 2014/05/23 13:28:32, kinuko wrote: > > PTL > ...
6 years, 7 months ago (2014-05-23 14:39:27 UTC) #3
nhiroki
LGTM, thanks!
6 years, 7 months ago (2014-05-23 15:24:06 UTC) #4
horo
lgtm
6 years, 7 months ago (2014-05-23 15:26:29 UTC) #5
michaeln
lgtm2
6 years, 7 months ago (2014-05-23 19:17:44 UTC) #6
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 7 months ago (2014-05-23 19:17:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/297903005/2
6 years, 7 months ago (2014-05-23 19:19:35 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 02:28:52 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 06:02:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/32370)
6 years, 7 months ago (2014-05-24 06:02:27 UTC) #11
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 7 months ago (2014-05-24 08:28:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/297903005/2
6 years, 7 months ago (2014-05-24 08:29:00 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 12:35:43 UTC) #14
Message was sent while issue was closed.
Change committed as 272717

Powered by Google App Engine
This is Rietveld 408576698