pkg/front_end/messages.yaml - Issue 2979003002: support resolving .packages in FE

Side by Side Diff: pkg/front_end/messages.yaml

Issue 2979003002: support resolving .packages in FE (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« pkg/front_end/lib/src/fasta/uri_translator_impl.dart ('K') | « pkg/front_end/lib/src/fasta/uri_translator_impl.dart ('k') | pkg/front_end/test/dependency_grapher_test.dart » ('j') | pkg/front_end/test/src/base/processed_options_test.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file

2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

4	4

5 # Each entry in this map corresponds to a diagnostic message. Ideally, each	5 # Each entry in this map corresponds to a diagnostic message. Ideally, each

6 # entry contains three parts:	6 # entry contains three parts:

7 #	7 #

8 # 1. A message template (template).	8 # 1. A message template (template).

9 #	9 #

10 # 2. A suggestion for how to correct the problem (tip).	10 # 2. A suggestion for how to correct the problem (tip).

(...skipping 772 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
783 tip: "Try changing the 'part of' declaration to use a relative file name."	783 tip: "Try changing the 'part of' declaration to use a relative file name."

784	784

785 PartOfUriMismatch:	785 PartOfUriMismatch:

786 template: "Using '#uri' as part of '#uri2' but its 'part of' declaration says '#string'."	786 template: "Using '#uri' as part of '#uri2' but its 'part of' declaration says '#string'."

787	787

788 MissingMain:	788 MissingMain:

789 template: "No 'main' method found."	789 template: "No 'main' method found."

790 tip: "Try adding a method named 'main' to your program."	790 tip: "Try adding a method named 'main' to your program."

791 dart2jsCode: MISSING_MAIN	791 dart2jsCode: MISSING_MAIN

792	792

	793 MissingInputs:

	794 template: "No input files provided to the compiler."
	ahe 2017/07/14 13:44:58 files -> file. files -> file. Siggi Cherem (dart-lang) 2017/07/14 19:54:06 Done. Show quoted text On 2017/07/14 13:44:58, ahe wrote: > files -> file. Done.
	795

793 MissingInputFile:	796 MissingInputFile:

794 template: "Input file not found: #string."	797 template: "Input file not found: #string."

795	798

796 MissingSdkRoot:	799 MissingSdkRoot:

797 template: "SDK root directory not found: #string."	800 template: "SDK root directory not found: #string."

798	801

799 MissingSdkSummary:	802 MissingSdkSummary:

800 template: "SDK summary not found: #string."	803 template: "SDK summary not found: #string."

801	804

802 ThisAccessInFieldInitializer:	805 ThisAccessInFieldInitializer:

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
839 template: "Constructor is marked 'const' so all fields must be final."	842 template: "Constructor is marked 'const' so all fields must be final."

840	843

841 ConstConstructorNonFinalFieldCause:	844 ConstConstructorNonFinalFieldCause:

842 template: "Field isn't final, but constructor is 'const'."	845 template: "Field isn't final, but constructor is 'const'."

843	846

844 AccessError:	847 AccessError:

845 template: "Access error: '#name'."	848 template: "Access error: '#name'."

846	849

847 PreviousUseOfName:	850 PreviousUseOfName:

848 template: "Previous use of '#name'."	851 template: "Previous use of '#name'."

	852

	853 InvalidPackagesFile:

	854 template: "Invalid .packages file '#uri':\n #string."
	ahe 2017/07/14 13:44:58 Invalid is a word that we should avoid. How about: Invalid is a word that we should avoid. How about: "Unable to read '.packages' file:\n #string" Also, in this case, the uri should be in the location, not the message. Siggi Cherem (dart-lang) 2017/07/14 19:54:06 Done. However, now that I am catching the argument Show quoted text On 2017/07/14 13:44:58, ahe wrote: > Invalid is a word that we should avoid. How about: > > "Unable to read '.packages' file:\n #string" > Done. However, now that I am catching the argument-errors from the package-uri validation, I have a new error that says "invalid". Suggestions are welcomed. Show quoted text > Also, in this case, the uri should be in the location, not the message. Done, but let's discuss what are the invariants about location here. I had in mind that location is a point where they can fix the issue. If the problem is in the input file, location is the file + offset, if the problem is a flag, we can't really use the location URI. In this case the error could be the file, or the flag (pointing to the wrong .packages file), in which case I'm not sure I want to use the broken uri as the location. A different example, if an import has a URi that doesn't exist, I believe the location should point to the import, but the message should mention the URI.
OLD	NEW