Issue 2979003: Reworked ChromeSystemResources to handle callbacks properly.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2979003: Reworked ChromeSystemResources to handle callbacks properly. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by akalin

Modified:
4 years ago

Reviewers:
timsteele

CC:
chromium-reviews, ncarter, ben+cc_chromium.org, Raghu Simha, idana, Paweł Hajdan Jr., timsteele

Visibility:
Public.

Reworked ChromeSystemResources to handle callbacks properly. Added unit tests. BUG=48874 TEST=new unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52204

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -28 lines)			Patch
M	chrome/browser/sync/notifier/chrome_system_resources.h	View		2 chunks	+20 lines, -9 lines	0 comments	Download
M	chrome/browser/sync/notifier/chrome_system_resources.cc	View		2 chunks	+43 lines, -19 lines	0 comments	Download
A	chrome/browser/sync/notifier/chrome_system_resources_unittest.cc	View	1	1 chunk	+106 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Trybot results: mac linux win

Total messages: 3 (0 generated)

akalin

Oops, fixed a compile error that sneaked in. On 2010/07/13 01:36:44, akalin wrote: > +tim ...

4 years, 10 months ago (2010-07-13 04:50:56 UTC) #2

LGTM, discussed this with Fred.