Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Issue 2978993002: translate more fasta error codes to analyzer error codes (Closed)

Created:
3 years, 5 months ago by danrubel
Modified:
3 years, 5 months ago
Reviewers:
Paul Berry, ahe
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update tests that are now passing #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 2 chunks +17 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 2 chunks +0 lines, -24 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 1 4 chunks +4 lines, -3 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
danrubel
3 years, 5 months ago (2017-07-13 22:22:04 UTC) #2
Paul Berry
lgtm
3 years, 5 months ago (2017-07-13 22:31:30 UTC) #3
ahe
lgtm
3 years, 5 months ago (2017-07-14 12:17:15 UTC) #5
danrubel
3 years, 5 months ago (2017-07-14 16:31:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
bb9ba11c6c7a1beb88835b94bf830f47b638e878 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698