Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2122)

Unified Diff: extensions/browser/script_executor.cc

Issue 2978953002: [Extensions] Don't allow content scripts on the New Tab Page (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/script_executor.cc
diff --git a/extensions/browser/script_executor.cc b/extensions/browser/script_executor.cc
index db2c02da3031784a258f5e4abb7ac972cee8d177..1f6c10eab3815b520f8b8d2e4b2d841707436dcd 100644
--- a/extensions/browser/script_executor.cc
+++ b/extensions/browser/script_executor.cc
@@ -135,6 +135,8 @@ class Handler : public content::WebContentsObserver {
DCHECK(erased);
bool is_root_frame = root_rfh_ == render_frame_host;
+ LOG(WARNING) << "Done: " << error << ", " << on_url;
+
// Set the result, if there is one.
const base::Value* script_value = nullptr;
if (result_list.Get(0u, &script_value)) {
@@ -158,9 +160,11 @@ class Handler : public content::WebContentsObserver {
void Finish() {
if (root_frame_url_.is_empty()) {
+ LOG(WARNING) << "Failed: " << root_frame_error_;
// We never finished the root frame injection.
root_frame_error_ =
root_is_main_frame_ ? kRendererDestroyed : kFrameRemoved;
+ LOG(WARNING) << "New: " << root_frame_error_;
results_.Clear();
}

Powered by Google App Engine
This is Rietveld 408576698