chrome/test/data/extensions/api_test/content_scripts/ntp/manifest.json - Issue 2978953002: [Extensions] Don't allow content scripts on the New Tab Page

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/content_scripts/ntp/manifest.json

Issue 2978953002: [Extensions] Don't allow content scripts on the New Tab Page (Closed)

Patch Set: . Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/data/extensions/api_test/content_scripts/ntp/background.js ('K') | « chrome/test/data/extensions/api_test/content_scripts/ntp/background.js ('k') | chrome/test/data/extensions/api_test/content_scripts/ntp/script.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "name": "New Tab Page Injector",

	3 "version": "0.1",

	4 "manifest_version": 2,

	5 "description": "Injects in the NTP",

	6 "content_scripts": [{

	7 "matches": [":///*"],

	8 "js": ["script.js"],

	9 "run_at": "document_start"
	karandeepb 2017/07/18 21:06:25 For my own knowledge, why didn't document_start/wi For my own knowledge, why didn't document_start/window.didInject work? Devlin 2017/07/18 21:12:49 window.didInject didn't work because the content s Show quoted text On 2017/07/18 21:06:25, karandeepb wrote: > For my own knowledge, why didn't document_start/window.didInject work? window.didInject didn't work because the content script (or script added by tabs.executeScript) executes in an isolated world, so the variables aren't exposed to the main world - which is where content::ExecuteScriptAndExtract* are executed. As a workaround, we can modify the DOM, so that the changes are visible to the main world script context, even though they were performed in an isolated world. So that leads us to using document.title instead of window.didInject. From there, document_start is just too early in the rendering process for document.title to be assigned, so we need to wait 'til at least document_end. karandeepb 2017/07/18 21:27:18 Makes sense! Thanks. Show quoted text On 2017/07/18 21:12:49, Devlin wrote: > On 2017/07/18 21:06:25, karandeepb wrote: > > For my own knowledge, why didn't document_start/window.didInject work? > > window.didInject didn't work because the content script (or script added by > tabs.executeScript) executes in an isolated world, so the variables aren't > exposed to the main world - which is where content::ExecuteScriptAndExtract* are > executed. As a workaround, we can modify the DOM, so that the changes are > visible to the main world script context, even though they were performed in an > isolated world. So that leads us to using document.title instead of > window.didInject. From there, document_start is just too early in the rendering > process for document.title to be assigned, so we need to wait 'til at least > document_end. Makes sense! Thanks.
	10 }],

	11 "background": {"scripts": ["background.js"]},

	12 "permissions": ["tabs", ":///*"]

	13 }

OLD	NEW