Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: LayoutTests/inspector/profiler/heap-snapshot-test.js

Issue 297893003: Devtools: DataGrid: do not render hidden columns. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix tests & nit Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 var initialize_HeapSnapshotTest = function() { 1 var initialize_HeapSnapshotTest = function() {
2 2
3 InspectorTest.createHeapSnapshotMockFactories = function() { 3 InspectorTest.createHeapSnapshotMockFactories = function() {
4 4
5 InspectorTest.createJSHeapSnapshotMockObject = function() 5 InspectorTest.createJSHeapSnapshotMockObject = function()
6 { 6 {
7 return { 7 return {
8 _rootNodeIndex: 0, 8 _rootNodeIndex: 0,
9 _nodeTypeOffset: 0, 9 _nodeTypeOffset: 0,
10 _nodeNameOffset: 1, 10 _nodeNameOffset: 1,
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
570 setTimeout(callCallback, 0); 570 setTimeout(callCallback, 0);
571 } 571 }
572 parent.addEventListener(WebInspector.HeapSnapshotGridNode.Events.PopulateCom plete, populateComplete, this); 572 parent.addEventListener(WebInspector.HeapSnapshotGridNode.Events.PopulateCom plete, populateComplete, this);
573 row[buttonName].click(); 573 row[buttonName].click();
574 }; 574 };
575 575
576 InspectorTest.columnContents = function(column, row) 576 InspectorTest.columnContents = function(column, row)
577 { 577 {
578 // Make sure invisible nodes are removed from the view port. 578 // Make sure invisible nodes are removed from the view port.
579 this._currentGrid().updateVisibleNodes(); 579 this._currentGrid().updateVisibleNodes();
580 var columnOrdinal = InspectorTest.viewColumns().indexOf(column);
580 var result = []; 581 var result = [];
581 var parent = row || this._currentGrid().rootNode(); 582 var parent = row || this._currentGrid().rootNode();
582 for (var node = parent.children[0]; node; node = node.traverseNextNode(true, parent, true)) { 583 for (var node = parent.children[0]; node; node = node.traverseNextNode(true, parent, true)) {
583 if (!node.selectable) 584 if (!node.selectable)
584 continue; 585 continue;
585 var content = node.element.children[column.ordinal]; 586 var content = node.element.children[columnOrdinal];
586 // Do not inlcude percents 587 // Do not inlcude percents
587 if (content.firstElementChild) 588 if (content.firstElementChild)
588 content = content.firstElementChild; 589 content = content.firstElementChild;
589 result.push(content.textContent); 590 result.push(content.textContent);
590 } 591 }
591 return result; 592 return result;
592 }; 593 };
593 594
594 InspectorTest.countDataRows = function(row, filter) 595 InspectorTest.countDataRows = function(row, filter)
595 { 596 {
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
725 function sortingComplete() 726 function sortingComplete()
726 { 727 {
727 dataGrid.removeEventListener(WebInspector.HeapSnapshotSortableDataGr id.Events.SortingComplete, sortingComplete, null); 728 dataGrid.removeEventListener(WebInspector.HeapSnapshotSortableDataGr id.Events.SortingComplete, sortingComplete, null);
728 callback(); 729 callback();
729 } 730 }
730 dataGrid.addEventListener(WebInspector.HeapSnapshotSortableDataGrid.Even ts.SortingComplete, sortingComplete, null); 731 dataGrid.addEventListener(WebInspector.HeapSnapshotSortableDataGrid.Even ts.SortingComplete, sortingComplete, null);
731 } 732 }
732 }; 733 };
733 734
734 }; 735 };
OLDNEW
« no previous file with comments | « no previous file | Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698