Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Issue 2978823002: [SelectMiss...Async #2] Change ContextMenuClient::SelectMisspellingAsync() to return pair of strings (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
index 8085acc7de19d679179e469822a569655a283ec7..40684020a25f189663e17ee0acaed7f3421d313b 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
@@ -77,7 +77,9 @@ class CORE_EXPORT SpellChecker final : public GarbageCollected<SpellChecker> {
FrameSelection::SetSelectionOptions);
Optional<std::pair<Node*, SpellCheckMarker*>>
GetSpellCheckMarkerTouchingSelection();
- String SelectMisspellingAsync(String& description);
+ // The first String returned in the pair is the selected text
+ // The second String is the marker's description
+ Optional<std::pair<String, String>> SelectMisspellingAsync();
void ReplaceMisspelledRange(const String&);
void RemoveSpellingMarkers();
void RemoveSpellingMarkersUnderWords(const Vector<String>& words);

Powered by Google App Engine
This is Rietveld 408576698