Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/libc++/BUILD.gn

Issue 2978723002: Only enable shared libc++ for ASan, MSan and TSan builds. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libc++/BUILD.gn
diff --git a/third_party/libc++/BUILD.gn b/third_party/libc++/BUILD.gn
index a236b80ddcb879bf66dfbf92b9354c6a2d563f13..1297799b583cb86ff12ef9b20c3a61fb456f5d05 100644
--- a/third_party/libc++/BUILD.gn
+++ b/third_party/libc++/BUILD.gn
@@ -5,10 +5,10 @@
import("//build/config/sanitizers/sanitizers.gni")
import("//build/toolchain/toolchain.gni")
-# Sanitizer builds need to override operator new, operator delete, and
+# ASan, MSan and TSan need to override operator new, operator delete, and
# some exception handling symbols, so libc++ must be a shared library
# to prevent duplicate symbol errors when linking.
-libcpp_is_static = !is_component_build && !using_sanitizer
+libcpp_is_static = !is_component_build && !is_asan && !is_msan && !is_tsan
# Used by libc++ and libc++abi.
config("config") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698