Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2978723002: Only enable shared libc++ for ASan, MSan and TSan builds. (Closed)

Created:
3 years, 5 months ago by pcc1
Modified:
3 years, 5 months ago
Reviewers:
Tom Anderson, Nico
Target Ref:
refs/heads/master
Project:
buildtools
Visibility:
Public.

Description

Only enable shared libc++ for ASan, MSan and TSan builds. The UBSan runtime, which is also used by CFI, does not override the allocator functions, so there is no need to link libc++ dynamically if the UBSan runtime is being linked. The goal is to ensure that CFI coverage when building with use_cfi_diag is the same as when building without, and to avoid potential false positives in the standard library when building with use_cfi_icall. BUG=701919 R=thakis@chromium.org, thomasanderson@chromium.org Committed: 3d2d34dde457f07ca410d1c06f4f3b9063c28643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/libc++/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pcc1
3 years, 5 months ago (2017-07-12 01:27:35 UTC) #1
Tom Anderson
On 2017/07/12 01:27:35, pcc1 wrote: lgtm; when you roll in Chromium, please also update these ...
3 years, 5 months ago (2017-07-12 01:33:55 UTC) #2
Nico
lgtm
3 years, 5 months ago (2017-07-12 01:36:40 UTC) #3
pcc1
3 years, 5 months ago (2017-07-12 01:41:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3d2d34dde457f07ca410d1c06f4f3b9063c28643 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698