Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 297863005: Call net::EnsureNSSSSLInit() in the remoting client (Closed)

Created:
6 years, 7 months ago by Sergey Ulanov
Modified:
6 years, 7 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@git-svn
Visibility:
Public.

Description

Call talk_base::InitializeSSL() in the remoting client Previously the client was calling EnsureSSLServerSockets(), which internally calls EnsureNSSSSLInit(). It's not necessary to initialize server socket so that call was removed in r263951, and NSS is no longer initialized, which sometimes breaks the client (see the bug). Also removed the workaround. BUG=364689 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272789

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M remoting/client/plugin/chromoting_instance.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M remoting/protocol/libjingle_transport_factory.cc View 4 chunks +4 lines, -19 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
Sergey Ulanov
6 years, 7 months ago (2014-05-22 22:12:19 UTC) #1
Jamie
lgtm
6 years, 7 months ago (2014-05-23 00:13:44 UTC) #2
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 7 months ago (2014-05-23 00:43:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/297863005/1
6 years, 7 months ago (2014-05-23 00:45:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 04:35:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 04:55:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/19467)
6 years, 7 months ago (2014-05-23 04:55:16 UTC) #7
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 7 months ago (2014-05-23 19:15:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/297863005/20001
6 years, 7 months ago (2014-05-23 19:15:46 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 22:48:44 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 23:14:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/19819)
6 years, 7 months ago (2014-05-23 23:14:39 UTC) #12
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 7 months ago (2014-05-24 01:41:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/297863005/40001
6 years, 7 months ago (2014-05-24 01:41:35 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 07:43:01 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 07:49:05 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77383)
6 years, 7 months ago (2014-05-24 07:49:05 UTC) #17
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 7 months ago (2014-05-25 07:29:24 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/297863005/40001
6 years, 7 months ago (2014-05-25 07:29:28 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-25 07:55:00 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-25 08:20:01 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77475)
6 years, 7 months ago (2014-05-25 08:20:01 UTC) #22
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 7 months ago (2014-05-26 02:29:22 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/297863005/40001
6 years, 7 months ago (2014-05-26 02:30:24 UTC) #24
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 02:36:39 UTC) #25
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 04:29:10 UTC) #26
Message was sent while issue was closed.
Change committed as 272789

Powered by Google App Engine
This is Rietveld 408576698