Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2978613002: Convert data objects eagerly from K to J (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -342 lines) Patch
M pkg/compiler/lib/src/js_backend/native_data.dart View 2 chunks +16 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_model/elements.dart View 4 chunks +48 lines, -242 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 7 chunks +209 lines, -68 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 3 chunks +1 line, -24 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
3 years, 5 months ago (2017-07-11 13:09:05 UTC) #2
Siggi Cherem (dart-lang)
lgtm +efortuna as FYI: this seems to be unrelated to your code, maybe except that ...
3 years, 5 months ago (2017-07-11 21:10:25 UTC) #4
Johnni Winther
3 years, 5 months ago (2017-07-12 08:58:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
15e981d88ef632207e720308b4cb47f26e64c34a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698