Issue 297853007: rather than committing new unreviewed expectations, just ignore the failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297853007: rather than committing new unreviewed expectations, just ignore the failures (Closed)

Created:
6 years, 7 months ago by epoger

Modified:
6 years, 7 months ago

Reviewers:
fmalita_google_do_not_use

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

rather than committing new unreviewed expectations, just ignore the failures This way, subsequent runs of the bots will try to re-upload the image file. (They don't try to upload images for passing tests.) BUG=skia:2603 NOTREECHECKS=True NOTRY=True TBR=fmalita Committed: http://code.google.com/p/skia/source/detail?r=14879

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -16 lines)			Patch
M	expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/297853007/1

6 years, 7 months ago (2014-05-23 19:22:07 UTC) #3

Message was sent while issue was closed.

Change committed as 14879

Expand Messages | Collapse Messages