Make sure auth error reporting handles guest mode correctly.

Make sure auth error reporting handles guest mode correctly.

BUG=376648
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273070

[Roger Tawa OOO till Jul 10th, 2014-05-23 16:50:01]

Hi Monica,

Please take a look.  Thanks,

[noms (inactive), 2014-05-23 16:59:55]

https://codereview.chromium.org/297853006/diff/1/chrome/browser/ui/views/prof...
File chrome/browser/ui/views/profiles/new_avatar_button.cc (right):

https://codereview.chromium.org/297853006/diff/1/chrome/browser/ui/views/prof...
chrome/browser/ui/views/profiles/new_avatar_button.cc:59: SigninErrorController*
GetSigninErrorController(Browser* browser) {
Maybe this should go in profiles_state.h, given that it gets defined twice (and
probably twice more for the Mac)

[Roger Tawa OOO till Jul 10th, 2014-05-23 20:54:37]

Thanks Monica.  PTAL.

https://codereview.chromium.org/297853006/diff/1/chrome/browser/ui/views/prof...
File chrome/browser/ui/views/profiles/new_avatar_button.cc (right):

https://codereview.chromium.org/297853006/diff/1/chrome/browser/ui/views/prof...
chrome/browser/ui/views/profiles/new_avatar_button.cc:59: SigninErrorController*
GetSigninErrorController(Browser* browser) {
On 2014/05/23 16:59:57, Monica Dinculescu wrote:
> Maybe this should go in profiles_state.h, given that it gets defined twice
(and
> probably twice more for the Mac)

Done.

[noms (inactive), 2014-05-23 20:57:19]

profiles lgtm, but you'll need a views owner :)

[Roger Tawa OOO till Jul 10th, 2014-05-23 21:05:27]

Hi Scott,

Can you please review the views changes?  Thanks.

[sky, 2014-05-23 22:46:48]

LGTM

[Roger Tawa OOO till Jul 10th, 2014-05-24 03:10:23]

The CQ bit was checked by rogerta@chromium.org

[commit-bot: I haz the power, 2014-05-24 03:10:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rogerta@chromium.org/297853006/20001

[commit-bot: I haz the power, 2014-05-24 03:40:56]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-05-24 03:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-24 03:44:13]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Roger Tawa OOO till Jul 10th, 2014-05-24 03:50:42]

The CQ bit was checked by rogerta@chromium.org

[commit-bot: I haz the power, 2014-05-24 03:51:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rogerta@chromium.org/297853006/20001

[commit-bot: I haz the power, 2014-05-24 04:24:10]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-05-24 04:44:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-24 04:44:14]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[Roger Tawa OOO till Jul 10th, 2014-05-24 11:57:11]

The CQ bit was checked by rogerta@chromium.org

[commit-bot: I haz the power, 2014-05-24 11:57:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rogerta@chromium.org/297853006/20001

[commit-bot: I haz the power, 2014-05-24 12:06:16]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-05-24 12:34:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-24 12:34:46]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[Roger Tawa OOO till Jul 10th, 2014-05-26 16:31:42]

The CQ bit was checked by rogerta@chromium.org

[commit-bot: I haz the power, 2014-05-26 16:32:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rogerta@chromium.org/297853006/60001

[commit-bot: I haz the power, 2014-05-26 19:38:09]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-26 20:03:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-26 20:03:31]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[Roger Tawa OOO till Jul 10th, 2014-05-27 20:56:11]

The CQ bit was checked by rogerta@chromium.org

[commit-bot: I haz the power, 2014-05-27 20:59:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rogerta@chromium.org/297853006/70001

[commit-bot: I haz the power, 2014-05-27 22:02:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-27 23:28:37]

Change committed as 273070