Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 297853005: Change the PKM decoder to adhere to sampler size (Closed)

Created:
6 years, 7 months ago by krajcevski
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Change the PKM decoder to adhere to sampler size This fixes a bug where the red and blue channels seemed to be swapped on some platforms after decoding, and brings it more in line with the logic already in libbmp. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14881

Patch Set 1 #

Patch Set 2 : Remove unused header file #

Patch Set 3 : Use scaled width and height from sampler #

Total comments: 4

Patch Set 4 : Few style changes. #

Patch Set 5 : Remove some whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M src/images/SkImageDecoder_pkm.cpp View 1 2 3 4 4 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
krajcevski
6 years, 7 months ago (2014-05-23 16:23:18 UTC) #1
krajcevski
libbmp used sampler.scaledWidth() and sampler.scaledHeight() for the config, so we probably should, too.
6 years, 7 months ago (2014-05-23 16:27:05 UTC) #2
robertphillips
l g t m in general (deferring to Hal who may know what's going on ...
6 years, 7 months ago (2014-05-23 17:55:20 UTC) #3
krajcevski
https://codereview.chromium.org/297853005/diff/40001/src/images/SkImageDecoder_pkm.cpp File src/images/SkImageDecoder_pkm.cpp (right): https://codereview.chromium.org/297853005/diff/40001/src/images/SkImageDecoder_pkm.cpp#newcode54 src/images/SkImageDecoder_pkm.cpp:54: // Setup the sampler... On 2014/05/23 17:55:20, robertphillips wrote: ...
6 years, 7 months ago (2014-05-23 18:06:43 UTC) #4
krajcevski
6 years, 7 months ago (2014-05-23 18:12:03 UTC) #5
hal.canary
lgtm
6 years, 7 months ago (2014-05-23 19:00:58 UTC) #6
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 7 months ago (2014-05-23 19:32:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/297853005/60001
6 years, 7 months ago (2014-05-23 19:32:25 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 20:01:03 UTC) #9
Message was sent while issue was closed. 
Change committed as 14881

Powered by Google App Engine
This is Rietveld 408576698