Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2978333002: Include TypeEnvironment into KernelResult. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include TypeEnvironment into KernelResult. We need it to use kernel.Expression.getStaticType(). R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a295f782c0ce53028c327b5e4be4fe7b01bbd1bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -16 lines) Patch
M pkg/front_end/lib/src/incremental/kernel_driver.dart View 5 chunks +32 lines, -16 lines 0 comments Download
M pkg/front_end/test/src/incremental/kernel_driver_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-07-19 16:27:08 UTC) #1
Paul Berry
lgtm
3 years, 5 months ago (2017-07-19 16:29:14 UTC) #2
scheglov
3 years, 5 months ago (2017-07-19 16:40:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a295f782c0ce53028c327b5e4be4fe7b01bbd1bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698