Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Unified Diff: chrome/common/extensions/api/braille_display_private.idl

Issue 297833015: Support standard keyboard keys emulated by the braille drivers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/braille_display_private.idl
diff --git a/chrome/common/extensions/api/braille_display_private.idl b/chrome/common/extensions/api/braille_display_private.idl
index 166b932ef7ea687d9de1678ca1cdfd0963118d60..16a91d0f602fd99d11153523852e8752054a7293 100644
--- a/chrome/common/extensions/api/braille_display_private.idl
+++ b/chrome/common/extensions/api/braille_display_private.idl
@@ -28,8 +28,13 @@ namespace brailleDisplayPrivate {
// Braille dot keys that were pressed, stored in the low-order bits.
// Dot 1 is stored in bit 0, dot2 in bit 1, etc.
long? brailleDots;
- // DOM keyboard event for a key that corresponds to a standard key.
- DOMString? standardKeyName;
+ // DOM keyboard event code. This is present when command is standard_key
+ // and the braille display event represents a non-alphanumeric key such
+ // as an arrow key or function key.
+ DOMString? standardKeyCode;
not at google - send to devlin 2014/05/23 22:26:20 aren't key codes integers?
David Tseng 2014/05/27 21:29:31 Had same question as kalman.
+ // DOM keyboard event character value. This is present if the
+ // braille key event corresponds to a character.
+ DOMString? standardKeyChar;
David Tseng 2014/05/27 21:29:31 Do we need both of these members or can we make th
David Tseng 2014/05/27 21:32:29 Also, is there a non-standard variant? (i.e. can w
// Whether the space key was pressed.
boolean? spaceKey;
// Whether the alt key was pressed.

Powered by Google App Engine
This is Rietveld 408576698