Support standard keyboard keys emulated by the braille drivers.

chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef USE_BRLAPI
 #error This test requires brlapi.
 #endif
 
 #include <deque>
 
@@ skipping 24 matching lines @@
 using content::BrowserThread;
 
 namespace extensions {
 namespace api {
 namespace braille_display_private {
 
 namespace {
 
 const char kTestUserName[] = "owner@invalid.domain";
 
+// Used to make ReadKeys return an error.
+brlapi_keyCode_t kErrorKeyCode = BRLAPI_KEY_MAX;
+
 }  // namespace
 
 // Data maintained by the mock BrlapiConnection.  This data lives throughout
 // a test, while the api implementation takes ownership of the connection
 // itself.
 struct MockBrlapiConnectionData {
   bool connected;
   size_t display_size;
   brlapi_error_t error;
   std::vector<std::string> written_content;
@@ skipping 52 matching lines @@
 
   virtual bool WriteDots(const unsigned char* cells) OVERRIDE {
     std::string written(reinterpret_cast<const char*>(cells),
                         data_->display_size);
     data_->written_content.push_back(written);
     return true;
   }
 
   virtual int ReadKey(brlapi_keyCode_t* key_code) OVERRIDE {
     if (!data_->pending_keys.empty()) {
-      int queued_key_code = data_->pending_keys.front();
+      brlapi_keyCode_t queued_key_code = data_->pending_keys.front();
       data_->pending_keys.pop_front();
-      if (queued_key_code < 0) {
+      if (queued_key_code == kErrorKeyCode) {
         data_->error.brlerrno = BRLAPI_ERROR_EOF;
         return -1;  // Signal error.
       }
       *key_code = queued_key_code;
       return 1;
     } else {
       return 0;
     }
   }
 
@@ skipping 57 matching lines @@
     ASSERT_EQ(std::string(
         connection_data_.display_size,
         static_cast<char>(i)),
                  connection_data_.written_content[i])
         << "String " << i << " doesn't match";
   }
 }
 
 IN_PROC_BROWSER_TEST_F(BrailleDisplayPrivateApiTest, KeyEvents) {
   connection_data_.display_size = 11;
+
+  // Braille navigation commands.
   connection_data_.pending_keys.push_back(BRLAPI_KEY_TYPE_CMD |
                                           BRLAPI_KEY_CMD_LNUP);
   connection_data_.pending_keys.push_back(BRLAPI_KEY_TYPE_CMD |
                                           BRLAPI_KEY_CMD_LNDN);
   connection_data_.pending_keys.push_back(BRLAPI_KEY_TYPE_CMD |
                                           BRLAPI_KEY_CMD_FWINLT);
   connection_data_.pending_keys.push_back(BRLAPI_KEY_TYPE_CMD |
                                           BRLAPI_KEY_CMD_FWINRT);
   connection_data_.pending_keys.push_back(BRLAPI_KEY_TYPE_CMD |
                                           BRLAPI_KEY_CMD_TOP);
   connection_data_.pending_keys.push_back(BRLAPI_KEY_TYPE_CMD |
                                           BRLAPI_KEY_CMD_BOT);
   connection_data_.pending_keys.push_back(BRLAPI_KEY_TYPE_CMD |
                                           BRLAPI_KEY_CMD_ROUTE | 5);
-  // Space (0) and all combinations of dots.
+
+  // Braille display standard keyboard emulation.
+
+  // An ascii character.
+  connection_data_.pending_keys.push_back(BRLAPI_KEY_TYPE_SYM | 'A');
+  // A non-ascii 'latin1' character.  Small letter a with ring above.
+  connection_data_.pending_keys.push_back(BRLAPI_KEY_TYPE_SYM | 0xE5);
+  // A non-latin1 Unicode character.  LATIN SMALL LETTER A WITH MACRON.
+  connection_data_.pending_keys.push_back(
+      BRLAPI_KEY_TYPE_SYM | BRLAPI_KEY_SYM_UNICODE | 0x100);
+  // A Unicode character outside the BMP.  CAT FACE WITH TEARS OF JOY.
+  // With anticipation for the first emoji-enabled braille display.
+  connection_data_.pending_keys.push_back(
+      BRLAPI_KEY_TYPE_SYM | BRLAPI_KEY_SYM_UNICODE | 0x1F639);
+  // Invalid Unicode character.
+  connection_data_.pending_keys.push_back(
+      BRLAPI_KEY_TYPE_SYM | BRLAPI_KEY_SYM_UNICODE | 0x110000);
+
+  // Non-alphanumeric function keys.
+
+  // Backspace.
+  connection_data_.pending_keys.push_back(
+      BRLAPI_KEY_TYPE_SYM | BRLAPI_KEY_SYM_BACKSPACE);
+  // Shift+Tab.
+  connection_data_.pending_keys.push_back(
+      BRLAPI_KEY_TYPE_SYM | BRLAPI_KEY_FLG_SHIFT | BRLAPI_KEY_SYM_TAB);
+  // Alt+F3. (0-based).
+  connection_data_.pending_keys.push_back(
+      BRLAPI_KEY_TYPE_SYM | BRLAPI_KEY_FLG_META |
+      (BRLAPI_KEY_SYM_FUNCTION + 2));
+
+  // ctrl+dot1+dot2.
+  connection_data_.pending_keys.push_back(
+      BRLAPI_KEY_TYPE_CMD | BRLAPI_KEY_FLG_CONTROL | BRLAPI_KEY_CMD_PASSDOTS |
+      BRLAPI_DOT1 | BRLAPI_DOT2);
+
+  // Braille dot keys, all combinations including space (0).
   for (int i = 0; i < 256; ++i) {
     connection_data_.pending_keys.push_back(BRLAPI_KEY_TYPE_CMD |
                                             BRLAPI_KEY_CMD_PASSDOTS | i);
   }
+
   ASSERT_TRUE(RunComponentExtensionTest("braille_display_private/key_events"));
 }
 
 IN_PROC_BROWSER_TEST_F(BrailleDisplayPrivateApiTest, DisplayStateChanges) {
   connection_data_.display_size = 11;
-  connection_data_.pending_keys.push_back(-1);
+  connection_data_.pending_keys.push_back(kErrorKeyCode);
   connection_data_.reappear_on_disconnect = true;
   ASSERT_TRUE(RunComponentExtensionTest(
       "braille_display_private/display_state_changes"));
 }
 
 class BrailleDisplayPrivateAPIUserTest : public BrailleDisplayPrivateApiTest {
  public:
   virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
     command_line->AppendSwitch(chromeos::switches::kLoginManager);
     command_line->AppendSwitchASCII(chromeos::switches::kLoginProfile,
@@ skipping 89 matching lines @@
   DismissLockScreen(tester.get());
   signin_api.OnBrailleKeyEvent(key_event);
   user_api.OnBrailleKeyEvent(key_event);
   EXPECT_EQ(1, signin_delegate->GetEventCount());
   EXPECT_EQ(2, user_delegate->GetEventCount());
 }
 
 }  // namespace braille_display_private
 }  // namespace api
 }  // namespace extensions