linux_aura: Add Trusty libappindicator.

linux_aura: Add Trusty libappindicator.

BUG=374686
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272718

[Elliot Glaysher, 2014-05-23 18:20:18]

I don't actually have a way of testing this patch. I don't have vmware on my
machine, nor do I have a machine at work with trusty on it.

Could you please test this patch?

[pkotwicz, 2014-05-23 18:45:22]

LGTM. I have tested on Trusty and this fixes the issue. I am glad that it ends
up being simple.

For the sake of learning, what did you check in order to determine that it safe
to load libappindicator3.so.1?

The app indicator icon appears stretched and blurry but that has to do with the
size of the icon.

[Elliot Glaysher, 2014-05-23 19:24:05]

On 2014/05/23 18:45:22, pkotwicz wrote:
> LGTM. I have tested on Trusty and this fixes the issue. I am glad that it ends
> up being simple.
> 
> For the sake of learning, what did you check in order to determine that it
safe
> to load libappindicator3.so.1?
> 
> The app indicator icon appears stretched and blurry but that has to do with
the
> size of the icon.

I didn't do anything to check. I saw that you mentioned that you didn't see
anything in the interface that changed and I just updated the dlopen statements.

[Elliot Glaysher, 2014-05-23 19:24:08]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2014-05-23 19:24:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erg@chromium.org/297833013/1

[commit-bot: I haz the power, 2014-05-23 23:34:58]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-24 12:36:48]

Change committed as 272718

[tapted, 2014-05-26 00:07:39]

A revert of this CL has been created in
https://codereview.chromium.org/296393003/ by tapted@chromium.org.

The reason for reverting is: Suspected for waterfall failures "gsignal.c:2459:
signal `insert' is invalid" also possibly some obscure ASAN/LSAN errors

http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%...
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

[15124:15124:0524/063846:FATAL:browser_main_loop.cc(205)] GLib-GObject:
/build/buildd/glib2.0-2.32.4/./gobject/gsignal.c:2459: signal `insert' is
invalid for instance `0xcb71d63c0b0'
#0 0x7f91f99d3019 base::debug::StackTrace::StackTrace()
#1 0x7f91f9a4f139 logging::LogMessage::~LogMessage()
#2 0x7f920330e20d content::(anonymous namespace)::GLibLogHandler()
#3 0x7f91f3ab0f61 g_logv
#4 0x7f91f3ab1172 g_log
#5 0x7f91f3d7dd47 g_signal_connect_data
#6 0x7f91d9293efb <unknown>
#7 0x7f91d9294e8e <unknown>
#8 0x7f91d92961a8 dbusmenu_gtk_parse_menu_structure
#9 0x7f91d96af8fe app_indicator_set_menu
#10 0x7f91f8ac609b libgtk2ui::AppIndicatorIcon::SetMenu()
#11 0x7f91f8ac5e3a libgtk2ui::AppIndicatorIcon::SetImageFromFile()
#12 0x7f91f8ac92c8 base::internal::RunnableAdapter<>::Run()

==7567==ERROR: AddressSanitizer: heap-use-after-free on address 0x60800001e028
at pc 0x4cfb688 bp 0x7f4facffd2d0 sp 0x7f4facffd2c8
WRITE of size 4 at 0x60800001e028 thread T7 (CompositorRaste)

==14726==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 116 byte(s) in 2 object(s) allocated from:
    #0 0x5758ab in __interceptor_malloc
/usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75
    #1 0x7f52ed561a38 in g_malloc /build/buildd/glib2.0-2.32.4/./glib/gmem.c:159
.

[pkotwicz, 2014-05-26 14:28:22]

It looks like libappindicator3 links against gtk3
http://packages.ubuntu.com/precise/libappindicator3-1

Should we make libappindicator1 a dependency of Chrome? libappindicator
implements the X11 fallback so we should be able to use it in all cases