Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1505)

Unified Diff: mojo/apps/js/test/js_to_cpp.mojom

Issue 297833007: Fix handling of unexpected cases in bit-flip test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tidy comment. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/apps/js/test/js_to_cpp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/apps/js/test/js_to_cpp.mojom
diff --git a/mojo/apps/js/test/js_to_cpp.mojom b/mojo/apps/js/test/js_to_cpp.mojom
index 7dd036cc4c1655b1174e4d64e6ad0758c60b3f58..5747f88fed88f57544fe3d39be94cb505f94c162 100644
--- a/mojo/apps/js/test/js_to_cpp.mojom
+++ b/mojo/apps/js/test/js_to_cpp.mojom
@@ -28,9 +28,16 @@ struct EchoArgsList {
EchoArgs item;
};
+// Note: For messages which control test flow, pick numbers that are unlikely
viettrungluu 2014/05/22 19:24:18 Would it be better to use a completely separate in
+// to be hit as a result of our deliberate corruption of response messages.
interface CppSide {
- StartTest(); // Sent for all tests to notify that the JS side is now ready.
- TestFinished(); // Indicates end for echo, bit-flip, and back-pointer tests.
+ // Sent for all tests to notify that the JS side is now ready.
+ StartTest @88888888 ();
viettrungluu 2014/05/22 21:19:12 Style nit: Probably format this as: StartTest@8
Tom Sepez 2014/05/22 21:22:22 Done.
+
+ // Indicates end for echo, bit-flip, and back-pointer tests.
+ TestFinished @99999999 ();
viettrungluu 2014/05/22 21:19:12 "
Tom Sepez 2014/05/22 21:22:22 Done.
+
+ // Responses from specific tests.
PingResponse();
EchoResponse(EchoArgsList list);
BitFlipResponse(EchoArgsList arg);
« no previous file with comments | « no previous file | mojo/apps/js/test/js_to_cpp_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698