Add suite specific options argument to Android test bot.

Add suite specific options argument to Android test bot.

bb_device_steps.py's RunTestSuites took only one options
argument that will be applied for all the running test suites.
Add another suites_options argument so that the caller can
specify options on certain test suites.


BUG=368034
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272657

[Kibeom Kim (inactive), 2014-05-21 21:55:57]

bulach@ : I now have exactly the same problem again lol. I guess I want to add
an argument to RunTestSuites also.

[jbudorick, 2014-05-21 23:31:04]

https://codereview.chromium.org/297833002/diff/1/build/android/buildbot/bb_de...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/297833002/diff/1/build/android/buildbot/bb_de...
build/android/buildbot/bb_device_steps.py:120:
'"./clank/native/framework/clank_unittests.isolate"']
I don't think we want this hard-coded upstream (or downstream, for that matter).

This should either be accomplished by an extra argument to RunTestSuites, as
you've mentioned, or by adding to options, e.g.:

if options.isolate_file:
  args.extend(['--isolate_file_path', options.isolate_file])

[Kibeom Kim (inactive), 2014-05-21 23:41:24]

https://codereview.chromium.org/297833002/diff/1/build/android/buildbot/bb_de...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/297833002/diff/1/build/android/buildbot/bb_de...
build/android/buildbot/bb_device_steps.py:120:
'"./clank/native/framework/clank_unittests.isolate"']
On 2014/05/21 23:31:04, jbudorick wrote:
> I don't think we want this hard-coded upstream (or downstream, for that
matter).
> 
> This should either be accomplished by an extra argument to RunTestSuites, as
> you've mentioned, or by adding to options, e.g.:
> 
> if options.isolate_file:
>   args.extend(['--isolate_file_path', options.isolate_file])

options argument seems like a global option that is being applied to all the
suites passed in, so instead I added suites_options.

Here is how downstream calls it
https://chrome-internal-review.googlesource.com/#/c/164153/2/build/buildbot/b...
.

Actually, this doesn't look that ideal since clank_unittests always requires the
--isolate_file_path option and it's better to be tied together.

[jbudorick, 2014-05-22 00:01:48]

+navabi, as it's b/a/buildbot

I'm ok with this.

[bulach, 2014-05-22 10:30:43]

lgtm, yeah, it's a lot of fun passing these params around :)

minor suggestion below, please let navabi give the go ahead...

https://codereview.chromium.org/297833002/diff/20001/build/android/buildbot/b...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/297833002/diff/20001/build/android/buildbot/b...
build/android/buildbot/bb_device_steps.py:121: cmd += suites_options.get(suite,
())
nit: since cmd is a list, maybe for consistency use [] instead of ()

[Kibeom Kim (inactive), 2014-05-22 17:12:33]

https://codereview.chromium.org/297833002/diff/20001/build/android/buildbot/b...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/297833002/diff/20001/build/android/buildbot/b...
build/android/buildbot/bb_device_steps.py:121: cmd += suites_options.get(suite,
())
On 2014/05/22 10:30:43, bulach wrote:
> nit: since cmd is a list, maybe for consistency use [] instead of ()

Done.

[Kibeom Kim (inactive), 2014-05-22 21:31:00]

(adding another navabi for N+1 redundancy)

[navabi1, 2014-05-23 02:16:30]

lgtm

[Kibeom Kim (inactive), 2014-05-23 04:54:08]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-05-23 04:55:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/297833002/40001

[commit-bot: I haz the power, 2014-05-23 06:53:53]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-23 08:01:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-23 08:01:01]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Kibeom Kim (inactive), 2014-05-23 18:33:11]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-05-23 18:33:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/297833002/40001

[commit-bot: I haz the power, 2014-05-24 00:37:28]

Change committed as 272657