[milo] Add an (uncached) method to get console rows.

milo/api/resp/build.go

 // Copyright 2015 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 //go:generate stringer -type=Verbosity
 //go:generate stringer -type=ComponentType
 
 package resp
 
 import (
         "encoding/hex"
         "encoding/json"
+        "strings"
         "time"
 
         "golang.org/x/net/context"
 
         "github.com/luci/luci-go/common/logging"
         "github.com/luci/luci-go/milo/common"
         "github.com/luci/luci-go/milo/common/model"
 )
 
 // MiloBuild denotes a full renderable Milo build page.
@@ skipping 64 matching lines @@
         // Full URL of the main source repository.
         Repo string
         // Branch of the repo.
         Branch string
         // Requested revision of the commit or base commit.
         RequestRevision *Link
         // Revision of the commit or base commit.
         Revision *Link
         // The commit message.
         Description string
-        // The commit title, usually the first line of the commit message.
-        Title string
         // Rietveld or Gerrit URL if the commit is a patch.
         Changelist *Link
         // Browsable URL of the commit.
         CommitURL string
         // List of changed filenames.
         File []string
 }
 
+// Title is the first line of the commit message (Description).
+func (c *Commit) Title() string {
+        switch lines := strings.SplitN(c.Description, "\n", 2); len(lines) {
+        case 0:
+                return ""
+        case 1:
+                return c.Description
+        default:
+                return lines[0]
+        }
+}
+
 // BuildProgress is a way to show progress.  Percent should always be specified.
 type BuildProgress struct {
         // The total number of entries. Shows up as a tooltip.  Leave at 0 to
         // disable the tooltip.
         total uint64
 
         // The number of entries completed.  Shows up as <progress> / <total>.
         progress uint64
 
         // A number between 0 to 100 denoting the percentage completed.
@@ skipping 178 matching lines @@
                                         ID:   []byte(rb.SourceStamp.Revision.Label),
                                 })
                                 consoles, err := common.GetConsolesForBuilder(c, bs.BuilderID)
                                 if err != nil {
                                         return err
                                 }
                                 for _, con := range consoles {
                                         // HACK(iannucci): Until we have real manifest support, console
                                         // definitions will specify their manifest as "REVISION", and we'll do
                                         // lookups with null URL fields.
-                                        bs.AddManifestRevisionIndex(
+                                        bs.AddManifestKey(
                                                 con.ProjectID, con.Console.Name, "REVISION", "", revisionBytes)
                                 }
                         }
                 }
                 if rb.SourceStamp.Changelist != nil {
                         bs.Patches = append(bs.Patches, model.PatchInfo{
                                 Link:        rb.SourceStamp.Changelist.Link,
                                 AuthorEmail: rb.SourceStamp.AuthorEmail,
                         })
                 }
         }
         return nil
 }