[milo] Add an (uncached) method to get console rows.

milo/common/model/build_summary.go

 // Copyright 2017 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 54 matching lines @@
         Patches []PatchInfo
 
         // ManifestRevisionIndex has a single entry for each
         //   0 ++ project ++ console ++ manifest_name ++ url ++ revision.decode('hex')
         // which matched for this build. ++ is cmpbin concatenation.
         //
         // Example:
         //   0 ++ "chromium" ++ "main" ++ "UNPATCHED" ++ "https://.../src.git" ++ deadbeef
         //
         // The list of interested consoles is compiled at build summarization time.
         ManifestRevisionIndex [][]byte

[Ryan Tseng, 2017/07/19 08:07:58]

maybe "ManifestKey" is good enough?

[iannucci, 2017/07/20 00:14:56]

Done.

 }
 
 // AddManifestRevisionIndex adds a new entry to ManifestRevisionIndex.
 //
 // `revision` should be the hex-decoded git revision.
 //
 // It's up to the caller to ensure that entries in ManifestRevisionIndex aren't
 // duplicated.
 func (bs *BuildSummary) AddManifestRevisionIndex(project, console, manifest, repoURL string, revision []byte) {
+        bs.ManifestRevisionIndex = append(bs.ManifestRevisionIndex,
+                BuildSummaryPrefix(project, console, manifest, repoURL).AddRevision(revision))
+}
+
+// ManifestRevisionIndexPrefix is a binary prefix for querying

[Ryan Tseng, 2017/07/19 08:07:58]

Holy long names batman (not in the size of the name, but the number of concepts
a person needs to juggle in their head just from reading this variable name).

I'd say "ManifestRevisionIndexPrefix is an incomplete ManifestRevisionIndex
missing a git revision.  This can be converted into a full ManifestRevisionIndex
by supplying a git revision using AddRevision()"

If this was named "ManifestKey", then "ManifestKeyPrefix" would sound a lot more
natural.

[iannucci, 2017/07/20 00:14:56]

Done.

+// BuildSummary.ManifestRevisionIndex obtained from BuildSummaryPrefix.
+type ManifestRevisionIndexPrefix []byte
+
+// AddRevision appends a git revision (as bytes) to the
+// ManifestRevisionIndexPrefix, returning a full index value.
+func (m ManifestRevisionIndexPrefix) AddRevision(revision []byte) []byte {
+        var buf bytes.Buffer
+        buf.Write(m)
+        cmpbin.WriteBytes(&buf, revision)
+        return buf.Bytes()
+}
+
+// BuildSummaryPrefix generates a ManifestRevisionIndex prefix corresponding to
+// the given parameters.
+func BuildSummaryPrefix(project, console, manifest, repoURL string) ManifestRevisionIndexPrefix {
         var buf bytes.Buffer
         cmpbin.WriteUint(&buf, 0) // version
         cmpbin.WriteString(&buf, project)
         cmpbin.WriteString(&buf, console)
         cmpbin.WriteString(&buf, manifest)
         cmpbin.WriteString(&buf, repoURL)
-        cmpbin.WriteBytes(&buf, revision)
-        bs.ManifestRevisionIndex = append(bs.ManifestRevisionIndex, buf.Bytes())
+        return ManifestRevisionIndexPrefix(buf.Bytes())
 }