Add nonboxed closure class fields.

Add nonboxed closure class fields.

BUG=
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/dc99692b41522073fba4fb5ee1a3654361d0567e

[Emily Fortuna, 2017-07-19 00:03:19]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-07-19 00:10:29]

efortuna@google.com changed reviewers:
+ johnniwinther@google.com, sra@google.com

[Emily Fortuna, 2017-07-19 00:10:30]

Johnni, this goes with the clarifying question I emailed you about earlier
today. I'm running into another instance of needing an ir node for an entity
that doesn't have one. Try uncommenting out the line I have a comment on in this
CL and run python tools/test.py -m release
dart2js/kernel/compile_from_dill_fast_startup_test.

How do we want to deal with this?

https://codereview.chromium.org/2978263003/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2978263003/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/element_map_impl.dart:693: //_memberData.add(field);
This line is commented out because executing it causes these elements to get
added to the codegen work queue, which then causes the SSA builder to request
for the corresponding ir Node: 

NoSuchMethodError: Class 'ClosureField' has no instance getter 'node'.
Receiver: Instance of 'ClosureField'
Tried calling: node
#0      Object._noSuchMethod (dart:core-patch/object_patch.dart:42)
#1      Object.noSuchMethod (dart:core-patch/object_patch.dart:46)
#2      KernelToElementMapBase._getMemberNode
(package:compiler/src/kernel/element_map_impl.dart:606:44)
#3      JsKernelToElementMap.getMemberNode
(package:compiler/src/kernel/element_map_impl.dart:1967:12)
#4      KernelSsaBuilder.build
(package:compiler/src/kernel/kernel_backend_strategy.dart:97:21)
#5      SsaBuilderTask.build (package:compiler/src/ssa/ssa.dart:83:21)
#6      SsaFunctionCompiler.compile (package:compiler/src/ssa/ssa.dart:43:29)
#7      JavaScriptBackend.codegen
(package:compiler/src/js_backend/backend.dart:890:43)
#8      KernelCodegenWorkItem.run
(package:compiler/src/kernel/kernel_backend_strategy.dart:77:21)
#9      Compiler.emptyQueue.<anonymous closure>.<anonymous closure>.<anonymous
closure>.<anonymous closure>.<anonymous closure>
(package:compiler/src/compiler.dart:745:70)

What do you suggest, Johnni?

[Johnni Winther, 2017-07-19 10:47:12]

https://codereview.chromium.org/2978263003/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2978263003/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/element_map_impl.dart:693: //_memberData.add(field);
On 2017/07/19 00:10:30, Emily Fortuna wrote:
> This line is commented out because executing it causes these elements to get
> added to the codegen work queue, which then causes the SSA builder to request
> for the corresponding ir Node: 
> 
> NoSuchMethodError: Class 'ClosureField' has no instance getter 'node'.
> Receiver: Instance of 'ClosureField'
> Tried calling: node
> #0      Object._noSuchMethod (dart:core-patch/object_patch.dart:42)
> #1      Object.noSuchMethod (dart:core-patch/object_patch.dart:46)
> #2      KernelToElementMapBase._getMemberNode
> (package:compiler/src/kernel/element_map_impl.dart:606:44)
> #3      JsKernelToElementMap.getMemberNode
> (package:compiler/src/kernel/element_map_impl.dart:1967:12)
> #4      KernelSsaBuilder.build
> (package:compiler/src/kernel/kernel_backend_strategy.dart:97:21)
> #5      SsaBuilderTask.build (package:compiler/src/ssa/ssa.dart:83:21)
> #6      SsaFunctionCompiler.compile (package:compiler/src/ssa/ssa.dart:43:29)
> #7      JavaScriptBackend.codegen
> (package:compiler/src/js_backend/backend.dart:890:43)
> #8      KernelCodegenWorkItem.run
> (package:compiler/src/kernel/kernel_backend_strategy.dart:77:21)
> #9      Compiler.emptyQueue.<anonymous closure>.<anonymous closure>.<anonymous
> closure>.<anonymous closure>.<anonymous closure>
> (package:compiler/src/compiler.dart:745:70)
> 
> What do you suggest, Johnni?
>  

The need for the J-equivalent of ResolvedAst came sooner than expected. I'll
create it today.

[sra1, 2017-07-19 21:14:13]

lgtm

https://codereview.chromium.org/2978263003/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_model/closure.dart (right):

https://codereview.chromium.org/2978263003/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_model/closure.dart:158: parts.insert(0,
treeNode.name.name);
fyi We can just add() these since the parts is empty.

https://codereview.chromium.org/2978263003/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_model/closure.dart:193: return parts.join('_');
fyi maybe just always add and then do parts.reversed.join

[Emily Fortuna, 2017-07-19 22:30:13]

Description was changed from

==========
Add nonboxed closure class fields.

BUG=
==========

to

==========
Add nonboxed closure class fields.

BUG=
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dc99692b41522073fba4fb5ee1a3654361d0567e
==========

[Emily Fortuna, 2017-07-19 22:30:15]

Committed patchset #2 (id:40001) manually as
dc99692b41522073fba4fb5ee1a3654361d0567e (presubmit successful).

[Emily Fortuna, 2017-07-19 22:30:40]

https://codereview.chromium.org/2978263003/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_model/closure.dart (right):

https://codereview.chromium.org/2978263003/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_model/closure.dart:158: parts.insert(0,
treeNode.name.name);
On 2017/07/19 21:14:12, sra1 wrote:
> fyi We can just add() these since the parts is empty.

Done.

https://codereview.chromium.org/2978263003/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_model/closure.dart:193: return parts.join('_');
On 2017/07/19 21:14:12, sra1 wrote:
> fyi maybe just always add and then do parts.reversed.join

good call.