2nd try: SDK dep cleanup

2nd try: SDK dep cleanup

Retry https://github.com/dart-lang/sdk/commit/7a9cc03c09
Which was reverted at https://github.com/dart-lang/sdk/commit/b6d15d87bc

R=devoncarew@google.com

Committed: https://github.com/dart-lang/sdk/commit/500f5cb3242a0ff96eff7c5acb220e50f5357b28

[kevmoo, 2017-07-18 19:44:25]

kevmoo@google.com changed reviewers:
+ devoncarew@google.com, whesse@google.com

[devoncarew, 2017-07-18 19:54:45]

lgtm

Wow, lots of removed packages!

lgtm, w/ one question about re-using some code you're inlining from a package.

https://codereview.chromium.org/2978233002/diff/1/.packages
File .packages (right):

https://codereview.chromium.org/2978233002/diff/1/.packages#newcode65
.packages:65: observe:third_party/observatory_pub_packages/packages/observe/lib
This is a bit tricky; hopefully won't cause issues elsewhere.

(I see we do it elsewhere already, like for charted).

https://codereview.chromium.org/2978233002/diff/1/tests/html/utils.dart
File tests/html/utils.dart (right):

https://codereview.chromium.org/2978233002/diff/1/tests/html/utils.dart#newco...
tests/html/utils.dart:169: 
Is this the same code you're also adding to `tests/lib_strong/html/utils.dart`?
Can we share it?

[kevmoo, 2017-07-18 20:13:22]

On 2017/07/18 19:54:45, devoncarew wrote:
> lgtm
> 
> Wow, lots of removed packages!
> 
> lgtm, w/ one question about re-using some code you're inlining from a package.
> 
> https://codereview.chromium.org/2978233002/diff/1/.packages
> File .packages (right):
> 
> https://codereview.chromium.org/2978233002/diff/1/.packages#newcode65
> .packages:65:
observe:third_party/observatory_pub_packages/packages/observe/lib
> This is a bit tricky; hopefully won't cause issues elsewhere.
> 
> (I see we do it elsewhere already, like for charted).
> 
> https://codereview.chromium.org/2978233002/diff/1/tests/html/utils.dart
> File tests/html/utils.dart (right):
> 
>
https://codereview.chromium.org/2978233002/diff/1/tests/html/utils.dart#newco...
> tests/html/utils.dart:169: 
> Is this the same code you're also adding to
`tests/lib_strong/html/utils.dart`?
> Can we share it?

I theory, maybe? Look at the rest of the utils code – it's all a copy now.

I'm not making a future de-dupe any harder. :-)

[kevmoo, 2017-07-18 20:13:55]

Description was changed from

==========
2nd try: SDK dep cleanup

Retry https://github.com/dart-lang/sdk/commit/7a9cc03c09
Which was reverted at https://github.com/dart-lang/sdk/commit/b6d15d87bc
==========

to

==========
2nd try: SDK dep cleanup

Retry https://github.com/dart-lang/sdk/commit/7a9cc03c09
Which was reverted at https://github.com/dart-lang/sdk/commit/b6d15d87bc

R=devoncarew@google.com

Committed:
https://github.com/dart-lang/sdk/commit/500f5cb3242a0ff96eff7c5acb220e50f5357b28
==========

[kevmoo, 2017-07-18 20:13:56]

Committed patchset #1 (id:1) manually as
500f5cb3242a0ff96eff7c5acb220e50f5357b28 (presubmit successful).