Issue 2978223002: Dummy DDC implementation of MirrorSystem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2978223002: Dummy DDC implementation of MirrorSystem (Closed)

Created:
3 years, 5 months ago by vsm

Modified:
3 years, 5 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org, srawlins

Target Ref:
refs/heads/master

Visibility:
Public.

Dummy DDC implementation of MirrorSystem It's a bit absurd that a bunch of tests are passing with this. R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/ab39958ac5a0cbdecc10c7e3a73b6806669f34f4

Created: 3 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -12 lines)			Patch
M	pkg/dev_compiler/lib/sdk/ddc_sdk.sum	View	Binary file		0 comments	Download
M	pkg/dev_compiler/test/browser/language_tests.js	View	5 chunks	+2 lines, -10 lines	0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart	View	2 chunks	+9 lines, -2 lines	0 comments	Download

Total messages: 6 (3 generated)

vsm

3 years, 5 months ago (2017-07-18 20:00:36 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ab39958ac5a0cbdecc10c7e3a73b6806669f34f4 (presubmit successful).