Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2978213002: Removed DARTIUM codegen for IDLS (sdk/lib/dartium) (Closed)

Created:
3 years, 5 months ago by terry
Modified:
3 years, 5 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Removed emitted darttemplate from PYTHON code with #

Patch Set 3 : Restored whitespace #

Patch Set 4 : Removed all DART2JS - not needed its the default. #

Patch Set 5 : Removed all DART2JS - not needed its the default. #

Patch Set 6 : Few more removed. #

Patch Set 7 : Update generated darttemplate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2705 lines) Patch
M tools/dom/scripts/css_code_generator.py View 1 2 3 4 5 7 chunks +0 lines, -57 lines 0 comments Download
D tools/dom/src/dartium_CssClassSet.dart View 1 chunk +0 lines, -92 lines 0 comments Download
D tools/dom/src/dartium_CustomElementSupport.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D tools/dom/src/dartium_KeyEvent.dart View 1 chunk +0 lines, -175 lines 0 comments Download
D tools/dom/src/dartium_Platform.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tools/dom/src/dartium_WrappedEvent.dart View 1 chunk +0 lines, -96 lines 0 comments Download
D tools/dom/templates/html/dartium/chrome_dartium.darttemplate View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/dom/templates/html/dartium/cpp_callback_header.template View 1 chunk +0 lines, -61 lines 0 comments Download
D tools/dom/templates/html/dartium/cpp_callback_implementation.template View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/dom/templates/html/dartium/cpp_derived_sources.template View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/dom/templates/html/dartium/cpp_header.template View 1 chunk +0 lines, -74 lines 0 comments Download
D tools/dom/templates/html/dartium/cpp_implementation.template View 1 chunk +0 lines, -30 lines 0 comments Download
D tools/dom/templates/html/dartium/cpp_resolver.template View 1 chunk +0 lines, -19 lines 0 comments Download
D tools/dom/templates/html/dartium/dart_implementation.darttemplate View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +0 lines, -389 lines 0 comments Download
D tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate View 1 chunk +0 lines, -38 lines 0 comments Download
D tools/dom/templates/html/dartium/impl_MouseEvent.darttemplate View 1 chunk +0 lines, -79 lines 0 comments Download
D tools/dom/templates/html/dartium/indexed_db_dartium.darttemplate View 1 chunk +0 lines, -177 lines 0 comments Download
D tools/dom/templates/html/dartium/svg_dartium.darttemplate View 1 chunk +0 lines, -30 lines 0 comments Download
D tools/dom/templates/html/dartium/web_audio_dartium.darttemplate View 1 chunk +0 lines, -24 lines 0 comments Download
D tools/dom/templates/html/dartium/web_gl_dartium.darttemplate View 1 chunk +0 lines, -26 lines 0 comments Download
D tools/dom/templates/html/dartium/web_sql_dartium.darttemplate View 1 chunk +0 lines, -32 lines 0 comments Download
M tools/dom/templates/html/impl/impl_AudioContext.darttemplate View 1 2 3 3 chunks +0 lines, -20 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Blob.darttemplate View 1 2 3 2 chunks +0 lines, -19 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 2 3 4 5 6 7 chunks +0 lines, -57 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 1 2 3 11 chunks +0 lines, -71 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Comment.darttemplate View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CompositionEvent.darttemplate View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Crypto.darttemplate View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CustomEvent.darttemplate View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DOMException.darttemplate View 1 2 3 2 chunks +0 lines, -42 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DataTransferItemList.darttemplate View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 1 2 3 4 chunks +0 lines, -24 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentType.darttemplate View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 2 3 23 chunks +0 lines, -145 lines 0 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/dom/templates/html/impl/impl_FileReader.darttemplate View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Geolocation.darttemplate View 1 2 3 3 chunks +0 lines, -6 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLAudioElement.darttemplate View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 2 3 8 chunks +0 lines, -261 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLFrameSetElement.darttemplate View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLLinkElement.darttemplate View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTableElement.darttemplate View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTableRowElement.darttemplate View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTableSectionElement.darttemplate View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HashChangeEvent.darttemplate View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_History.darttemplate View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBCursor.darttemplate View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate View 1 2 3 2 chunks +0 lines, -24 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBFactory.darttemplate View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_ImageData.darttemplate View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Location.darttemplate View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_MediaStream.darttemplate View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_MessageEvent.darttemplate View 1 2 3 2 chunks +0 lines, -14 lines 0 comments Download
M tools/dom/templates/html/impl/impl_MutationObserver.darttemplate View 1 2 3 3 chunks +0 lines, -22 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Navigator.darttemplate View 1 2 3 4 chunks +0 lines, -14 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 2 3 6 chunks +0 lines, -42 lines 0 comments Download
M tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate View 1 2 3 4 chunks +0 lines, -11 lines 0 comments Download
M tools/dom/templates/html/impl/impl_RadioNodeList.darttemplate View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Range.darttemplate View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGCursorElement.darttemplate View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGFEDropShadowElement.darttemplate View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGGlyphRefElement.darttemplate View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGMPathElement.darttemplate View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_ServiceWorker.darttemplate View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_ServiceWorkerMessageEvent.darttemplate View 2 chunks +0 lines, -10 lines 0 comments Download
M tools/dom/templates/html/impl/impl_ShadowRoot.darttemplate View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Text.darttemplate View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Touch.darttemplate View 1 2 3 2 chunks +0 lines, -11 lines 0 comments Download
M tools/dom/templates/html/impl/impl_TouchEvent.darttemplate View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WebGL2RenderingContext.darttemplate View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WebGLRenderingContext.darttemplate View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WebKitCSSKeyframesRule.darttemplate View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WheelEvent.darttemplate View 1 2 3 3 chunks +0 lines, -28 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 2 3 9 chunks +3 lines, -66 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WorkerLocation.darttemplate View 1 chunk +0 lines, -12 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WorkerNavigator.darttemplate View 1 chunk +0 lines, -12 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 1 2 3 6 chunks +0 lines, -28 lines 0 comments Download
M tools/dom/templates/immutable_list_mixin.darttemplate View 1 2 3 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
terry
Committed patchset #7 (id:120001) manually as 621b12f3244aab800c15c64a4e18099eaf96e4f1 (presubmit successful).
3 years, 5 months ago (2017-07-18 18:02:14 UTC) #2
Alan Knight
3 years, 5 months ago (2017-07-18 20:39:03 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698